unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: "Jose A. Ortega Ruiz" <jao@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Add new debug meta-command ,error
Date: Mon, 30 Aug 2010 08:01:32 -0700	[thread overview]
Message-ID: <m3sk1wxhyr.fsf@unquote.localdomain> (raw)
In-Reply-To: <1283143931-6220-1-git-send-email-jao@gnu.org> (Jose A. Ortega Ruiz's message of "Mon, 30 Aug 2010 06:52:11 +0200")

Hi,

Thanks for the patch. Only one small comment; feel free to commit when
you're happy with it (I think you have access).

On Sun 29 Aug 2010 21:52, "Jose A. Ortega Ruiz" <jao@gnu.org> writes:

> +(define-meta-command (error repl)
> +  "error
> +Display the original error message."
> +  (let ((debug (repl-debug repl)))
> +     (format #t "~a~%" (if debug (debug-error-message debug) ""))))
> +

Perhaps use define-stack-command to handle the no-debug case. In any
case if there is no debug, we need a better message.

Thanks,

Andy
-- 
http://wingolog.org/



  reply	other threads:[~2010-08-30 15:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30  4:52 [PATCH] Add new debug meta-command ,error Jose A. Ortega Ruiz
2010-08-30 15:01 ` Andy Wingo [this message]
2010-08-30 19:39   ` Jose A. Ortega Ruiz
2010-08-30 20:44     ` Andy Wingo
2010-08-30 20:45       ` Jose A. Ortega Ruiz
2010-08-31  1:54         ` Andy Wingo
2010-08-31  2:30           ` Jose A. Ortega Ruiz
2010-08-31  3:23             ` Andy Wingo
2010-08-31 11:56               ` Jose A. Ortega Ruiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sk1wxhyr.fsf@unquote.localdomain \
    --to=wingo@pobox.com \
    --cc=guile-devel@gnu.org \
    --cc=jao@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).