From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.0-4-g3e05fc0 Date: Mon, 21 Feb 2011 22:19:41 +0100 Message-ID: References: <878vx96rjw.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1298322895 5834 80.91.229.12 (21 Feb 2011 21:14:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 Feb 2011 21:14:55 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Feb 21 22:14:50 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Prd5l-0005UL-Io for guile-devel@m.gmane.org; Mon, 21 Feb 2011 22:14:49 +0100 Original-Received: from localhost ([127.0.0.1]:39655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Prd5k-0000F0-QQ for guile-devel@m.gmane.org; Mon, 21 Feb 2011 16:14:48 -0500 Original-Received: from [140.186.70.92] (port=42880 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Prd5X-0000Ck-On for guile-devel@gnu.org; Mon, 21 Feb 2011 16:14:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Prd5U-0004vR-Fa for guile-devel@gnu.org; Mon, 21 Feb 2011 16:14:36 -0500 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:63988 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Prd5U-0004to-CY; Mon, 21 Feb 2011 16:14:32 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 8C3054E56; Mon, 21 Feb 2011 16:15:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=8Rm+ep9cLFyL u2R8EKCLSWxHXX4=; b=TcmE2trb52Qg1OfwsaQ9ZNNAhBHx8YpDDwNo9wF8LOLq xuH60mzvKmxqAgC1ezzV2X2XaDWPPx6JmBKD7U/uMRqJLcDid/x2D/mhZcqlKFyX DetELOy1BH2OOtc2jTasGtQ/65B7azEY1a2RuF/ZtdIqkHZXiETzskB1sWsCQ7U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=KkAJKz oz5A9DEKjUt/LO19V+4/gc6e0eSowGqINFrQdfb6a6IqaaqSHLUeylNs12ljyk5f 8F5hNQWGPZkFP4Z8AY2ORCTvZKjBWSuKMX3wFop7WndSug2DZ5FD5eE47tWZ4GOX b6Ontd6zGpA8bV0xJejtSzVFG2UNs9o0HhOP8= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 77CE14E55; Mon, 21 Feb 2011 16:15:39 -0500 (EST) Original-Received: from unquote.localdomain (unknown [90.164.198.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 72AB94E53; Mon, 21 Feb 2011 16:15:37 -0500 (EST) In-Reply-To: <878vx96rjw.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 21 Feb 2011 21:50:11 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: BB99FB26-3DFF-11E0-8A6B-AF401E47CF6F-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 64.74.157.62 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11673 Archived-At: On Mon 21 Feb 2011 21:50, ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> --- a/libguile/ports.c >> +++ b/libguile/ports.c >> @@ -661,6 +661,19 @@ scm_i_remove_port (SCM port) >> scm_port_non_buffer (p); >> p->putback_buf =3D NULL; >> p->putback_buf_size =3D 0; >> + >> + if (p->input_cd !=3D (iconv_t) -1) >> + { >> + iconv_close (p->input_cd); >> + p->input_cd =3D (iconv_t) -1; >> + } >> +=20=20 >> + if (p->output_cd !=3D (iconv_t) -1) >> + { >> + iconv_close (p->output_cd); >> + p->output_cd =3D (iconv_t) -1; >> + } >> + > > I don=E2=80=99t think this is needed: each port has a finalizer, > =E2=80=98finalize_port=E2=80=99, which normally takes care of this, event= ually. It is needed, but only in the case that you `close-port' explicitly. The block in finalize_port only takes care of gc'd open ports. Regards, Andy --=20 http://wingolog.org/