Should scm_c_run_hook be internal?

Should scm_c_run_hook be internal?

[Neil Jerram]

Documenting hooks, I just wrote the following about scm_c_run_hook:

-----------------
If, in C code, you are certain that you have a hook object and well
formed argument list for that hook, you can also use
@code{scm_c_run_hook}, which is identical to @code{scm_run_hook} but
does no type checking.

@deftypefn {C Function} void scm_c_run_hook (SCM hook, SCM args)
The same as @code{scm_run_hook} but without any type checking to confirm
that @var{hook} is actually a hook object and that @var{args} is a
well-formed list matching the arity of the hook.
@end deftypefn
-----------------

Is this right, or should scm_c_run_hook really be for internal use
only?  (And hence scm_i_run_hook?)  It's currently used from gc.c to
run the after-gc-hook.

        Neil


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: Should scm_c_run_hook be internal?

[Marius Vollmer]

Neil Jerram <neil@ossau.uklinux.net> writes:

> Documenting hooks, I just wrote the following about scm_c_run_hook:
> 
> -----------------
> If, in C code, you are certain that you have a hook object and well
> formed argument list for that hook, you can also use
> @code{scm_c_run_hook}, which is identical to @code{scm_run_hook} but
> does no type checking.
> 
> @deftypefn {C Function} void scm_c_run_hook (SCM hook, SCM args)
> The same as @code{scm_run_hook} but without any type checking to confirm
> that @var{hook} is actually a hook object and that @var{args} is a
> well-formed list matching the arity of the hook.
> @end deftypefn
> -----------------
> 
> Is this right, or should scm_c_run_hook really be for internal use
> only?  (And hence scm_i_run_hook?)  It's currently used from gc.c to
> run the after-gc-hook.

This is right.  I don't think scm_c_run_hook is an especially
important function to provide, but it isn't really dangerous either,
given your docs.

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel