From: Andy Wingo <wingo@pobox.com>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: port-filename and path canonicalization
Date: Tue, 20 Apr 2010 11:42:58 +0200 [thread overview]
Message-ID: <m3ochea28t.fsf@pobox.com> (raw)
In-Reply-To: <878w8jyr3w.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 20 Apr 2010 01:12:03 +0200")
Hi :)
On Tue 20 Apr 2010 01:12, ludo@gnu.org (Ludovic Courtès) writes:
> Andy Wingo <wingo@pobox.com> writes:
>
>> I recently added a global fluid, %file-port-name-canonicalization, which
>> defaults to #f. But if it's 'absolute, the port name of a file port will
>> be canonicalized to the absolute path; or, if it's 'relative, the port
>> name is the canonical name of the file, relative to the %load-path, or
>> the file name as given otherwise.
>>
>> The intention was to allow the user to control (port-filename P), so
>> that the user could find e.g. the absolute path corresponding to that
>> port at the time that it was made.
>
> My feeling is that ports shouldn’t have to deal with paths because
> that’s a separate concern. The %file-port-name-canonicalization fluid
> seems like an inelegant hack to me.
>
> When applications have special requirements about paths, then it should
> be up to the application logic to deal with that.
I am inclined to agree. A few complications cloud my view, though.
1. While ports do not have anything to do with file names / paths,
*file* ports certainly do -- because not only do they use the given path
to open the file, they set that path as the port's filename, providing
the only means for reverse-mapping ports to filenames (which is the end
goal here, reverse-mapping objects to filenames).
2. I think a fluid is still necessary, because a file being
compiled can do an `include' or `include-from-path', or even
`open-input-file' in a macro, and all these cases you would want the
same %file-port-name-canonicalization to take effect.
3. The only correct time to do a path canonicalization is when the file
is opened, because at another time, you might not be in the same current
directory, so relative paths would resolve incorrectly.
4. The application-level code is nastier if it has to canonicalize,
because a relative canonicalization cannot in general be passed to
open-input-file. For example
(open-input-file "../../module/ice-9/boot-9.scm")
is not the same as
(open-input-file "ice-9/boot-9.scm")
So you'd have to do a set-port-filename! on the port, mucking up your
code -- and how would you decide what to set? In N places you'd have to
duplicate fport_canonicalize_filename, and you'd probably have to make
scm_i_relativize_path public.
When I realized all of that I decided to go with the minimal correct
solution, though it is a bit hacky. Applications are still free to do
their own thing, as %file-port-name-canonicalization defaults to #f, but
the useful 'absolute and 'relative behaviors are more convenient and
robust.
I'd be happy to have some cleaner solution, though. Do you have any
ideas?
Cheers,
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2010-04-20 9:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 14:52 file names embedded in .go Andy Wingo
2010-04-19 21:46 ` Thien-Thi Nguyen
2010-04-20 0:08 ` Jose A. Ortega Ruiz
2010-04-20 11:35 ` Thien-Thi Nguyen
2010-04-20 19:15 ` Jose A. Ortega Ruiz
2010-04-21 7:45 ` Thien-Thi Nguyen
2010-04-20 9:45 ` Andy Wingo
2010-04-20 10:34 ` Thien-Thi Nguyen
2010-04-19 23:12 ` port-filename and path canonicalization Ludovic Courtès
2010-04-20 9:42 ` Andy Wingo [this message]
2010-04-20 11:15 ` Thien-Thi Nguyen
2010-04-21 8:49 ` Ludovic Courtès
2010-04-21 19:16 ` Thien-Thi Nguyen
2010-04-21 22:26 ` Ludovic Courtès
2010-04-22 7:42 ` Thien-Thi Nguyen
2010-04-20 16:57 ` Ludovic Courtès
2010-04-22 11:10 ` Andy Wingo
2010-04-22 12:50 ` Ludovic Courtès
2010-04-19 23:23 ` file names embedded in .go Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ochea28t.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).