From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: Some leftover bugs for this release Date: Wed, 16 Sep 2009 21:29:31 +0200 Message-ID: References: <502659.49613.qm@web37903.mail.mud.yahoo.com> <87my4v3mvh.fsf@gnu.org> <825239.92029.qm@web37901.mail.mud.yahoo.com> <873a6ngsst.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1253129857 8567 80.91.229.12 (16 Sep 2009 19:37:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Sep 2009 19:37:37 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 16 21:37:30 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mo0Jl-0003OC-98 for guile-devel@m.gmane.org; Wed, 16 Sep 2009 21:37:29 +0200 Original-Received: from localhost ([127.0.0.1]:45936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mo0Jk-0008Rf-OU for guile-devel@m.gmane.org; Wed, 16 Sep 2009 15:37:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mo0JT-0008D1-KJ for guile-devel@gnu.org; Wed, 16 Sep 2009 15:37:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mo0JP-00089l-SE for guile-devel@gnu.org; Wed, 16 Sep 2009 15:37:11 -0400 Original-Received: from [199.232.76.173] (port=60379 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mo0JP-00089Q-MA for guile-devel@gnu.org; Wed, 16 Sep 2009 15:37:07 -0400 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:63597 helo=sasl.smtp.pobox.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mo0JM-0000y5-89; Wed, 16 Sep 2009 15:37:04 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id B50CA53DEA; Wed, 16 Sep 2009 15:37:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=FNv8fMvM22e9 1fju7KQO52mWXqw=; b=n1jK+ixhQlIy+3KaphJT0P1ISYkQOVtJB+auzY+3mf2X tcjId4iBeZGbO8H8mnLcsx6cK3dQWeZzdSP3ixXo0Pgdjf6Lo9wNu+6v8rW4xlSu GuFfQT67+74KVPVxpfzvUgQ0iZ32aM2OrYJtBSGPj1pprSgl5HsFfkYVXpVeGGE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=LL6hrW GCJQm2tzWkd6tnLSdjsKnon9ANMRePQ2B4Z6ZfBw/RN7W2w2yC2QbEdcvSS8L9BU C0CDk/tX4Lc80l4Np2R/54LiEEPXkY2LxfUNkKSQslYElQSnRzDexXQyPLNSIDg4 4+z1HWMiIdkWcUW8xjHL0YTtvQZv5/B8EiZs4= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id A1B2753DE9; Wed, 16 Sep 2009 15:37:02 -0400 (EDT) Original-Received: from unquote (unknown [83.32.70.123]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 7901953DE8; Wed, 16 Sep 2009 15:36:59 -0400 (EDT) In-Reply-To: <873a6ngsst.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 16 Sep 2009 11:09:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) X-Pobox-Relay-ID: 4ED94C42-A2F8-11DE-AA39-8B19076EA04E-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9332 Archived-At: Hi, On Wed 16 Sep 2009 11:09, ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>> > 100 SCM >>> > 101 scm_array_handle_element_type (scm_t_array_handle *h) >>> > 102 { >>> > 103=20 >>> if (h->element_type < 0 || h->element_type > SCM_ARRAY_ELEMENT_TYPE_L= AST) >>> > 104 abort (); /* guile programming error */ >>> > 105 return scm_i_array_element_types[h->element_type]; >>> > 106 } >>>=20 >>> Hmm, an enum variable can possibly hold any integer value, so why would >>> this always be true? Are you actually hitting this? > > [...] > >> So when I enable -Wtype-limits on my build, it warns for any enum >> value that is beyond those enumerated in the type definition. The=20 >> smallest value in this enum is zero, hence the warning. > > Then we could just use =E2=80=98-Wtype-limits=E2=80=99 and remove the abo= ve run-time > check. Andy? The struct could get corrupted somehow of course. It's not a bad check, but the typechecker is working against us :P Andy --=20 http://wingolog.org/