From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: PEG Patches Date: Fri, 25 Mar 2011 19:06:07 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1301076365 27567 80.91.229.12 (25 Mar 2011 18:06:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 25 Mar 2011 18:06:05 +0000 (UTC) Cc: guile-devel To: Noah Lavine Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Mar 25 19:06:01 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q3BOZ-00033w-VS for guile-devel@m.gmane.org; Fri, 25 Mar 2011 19:06:00 +0100 Original-Received: from localhost ([127.0.0.1]:35199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3BOZ-0000yw-AE for guile-devel@m.gmane.org; Fri, 25 Mar 2011 14:05:59 -0400 Original-Received: from [140.186.70.92] (port=57414 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3BOV-0000xY-Ct for guile-devel@gnu.org; Fri, 25 Mar 2011 14:05:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q3BOU-0005Fe-3f for guile-devel@gnu.org; Fri, 25 Mar 2011 14:05:55 -0400 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:63783 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q3BOT-0005FG-VC for guile-devel@gnu.org; Fri, 25 Mar 2011 14:05:54 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 0CC604992; Fri, 25 Mar 2011 14:07:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=UW23wDmtDL77SiTzkzi7VfWCWBM=; b=dbuXcM P8ngj3zDleg+Mv1Qur/jbSp5Xt3iEuse4QNzp3Dz35cWqXWSSvlXk/33vq1mMA3D gVVoPZvIgTqlF88DmvvnGobsQa0W0+HG29VVW4xHgjjRKAiv8Q6zqN4x5DsAD5qB 2oHqJHz3YpQmUfqMqBwbibmhnX2AXmw6jBS7w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=OO9Zp6HA1FN2Ck12nQBTihoSnoOOZdFw KbGAzjZ6g1l5mXHiYDXcg3EYj4LawPM1J1XfDjnjVeG35we6san6NCVntSTCwoxn PZpt1BmcgI/IwcFEJk6xruyrvZbWPWJX3r9AiAuiq+/3M4S/rNjzSvKwQdDPKm4x 0tuDnEjZBrM= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id EF1774991; Fri, 25 Mar 2011 14:07:32 -0400 (EDT) Original-Received: from unquote.localdomain (unknown [90.164.198.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 46E43498E; Fri, 25 Mar 2011 14:07:30 -0400 (EDT) In-Reply-To: (Noah Lavine's message of "Sun, 6 Mar 2011 00:25:13 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: C18316FC-570A-11E0-99BE-E8AB60295C12-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 64.74.157.62 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11985 Archived-At: On Sun 06 Mar 2011 06:25, Noah Lavine writes: > Attached is a series of patches I've made for the wip-mlucy branch. It > splits the PEG code into several little modules which go in > module/ice-9/peg/. The original peg source file becomes very little. > At the end it finally loses its big eval-when wrapper. Cool! These cleanups are great. However... when you added the files, you did not add them to Makefile.am, so they don't get built. I went back to add them, but they don't compile, and it's because of the circularity we have discussed in other threads. I think the solution is to confront the circularity directly. It exists because the PEG s-exp grammar also deals with the string grammar, which needs an already-build PEG parser. Let's break it instead into layers without cycles: removing the string grammar from the s-exp code generator. If we want a layer with both, we build it on top of the two lower layers. What do you think? Andy -- http://wingolog.org/