unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: guile-devel <guile-devel@gnu.org>
Subject: request review: branch "wingo"
Date: Fri, 27 Mar 2009 16:29:55 -0700	[thread overview]
Message-ID: <m3hc1esfws.fsf@pobox.com> (raw)

Hi,

On the "wingo" branch in the main repository, you will find the
following patches:

    The following changes since commit 0fe95f9c4ce063781e79a15bc123c57c33ef9755:
      Ludovic Courtès (1):
            Improve wording in `libguile/Makefile.am' regarding stack calibration.

    are available in the git repository at:

      git.sv.gnu.org:/srv/git/guile.git wingo

    Andy Wingo (7):
          allow building against uninstalled guile; move some things to meta/
          add getrlimit and setrlimit wrappers
          getrlimit-based stack limits
          rely on getrlimit to DTRT, don't make stack calibration file
          fix check for guile-tools running uninstalled
          fix "linking" of guile-config
          fix distcheck hopefully, by cleaning the vm-i-*.i files

     .gitignore                                         |    1 -
     Makefile.am                                        |    9 +-
     README                                             |   20 ++-
     am/guilec                                          |    4 +-
     am/pre-inst-guile                                  |    2 +-
     check-guile.in                                     |    5 +-
     configure.in                                       |   16 +-
     doc/ref/Makefile.am                                |    4 +-
     gc-benchmarks/run-benchmark.scm                    |    2 +-
     libguile/Makefile.am                               |   25 +---
     libguile/debug.c                                   |   36 ++++
     libguile/measure-hwm.scm                           |  136 ---------------
     libguile/posix.c                                   |  174 ++++++++++++++++++++
     libguile/posix.h                                   |    2 +
     {guile-config => meta}/ChangeLog-2008              |    0 
     {guile-config => meta}/Makefile.am                 |   25 +--
     .../gdb-uninstalled-guile.in                       |   10 +-
     meta/guile-1.8-uninstalled.pc.in                   |    8 +
     guile-1.8.pc.in => meta/guile-1.8.pc.in            |    0 
     {guile-config => meta}/guile-config.in             |    7 +-
     guile-tools.in => meta/guile-tools.in              |    2 +-
     pre-inst-guile.in => meta/guile.in                 |    6 +-
     {guile-config => meta}/guile.m4                    |    0 
     pre-inst-guile-env.in => meta/uninstalled-env.in   |   17 ++-
     test-suite/standalone/Makefile.am                  |    2 +-
     test-suite/standalone/README                       |    2 +-
     test-suite/standalone/test-fast-slot-ref.in        |    2 +-
     test-suite/standalone/test-use-srfi.in             |    6 +-
     testsuite/Makefile.am                              |    2 +-
     29 files changed, 299 insertions(+), 226 deletions(-)
     delete mode 100644 libguile/measure-hwm.scm
     rename {guile-config => meta}/ChangeLog-2008 (100%)
     rename {guile-config => meta}/Makefile.am (59%)
     rename gdb-pre-inst-guile.in => meta/gdb-uninstalled-guile.in (79%)
     create mode 100644 meta/guile-1.8-uninstalled.pc.in
     rename guile-1.8.pc.in => meta/guile-1.8.pc.in (100%)
     rename {guile-config => meta}/guile-config.in (98%)
     rename guile-tools.in => meta/guile-tools.in (98%)
     rename pre-inst-guile.in => meta/guile.in (93%)
     rename {guile-config => meta}/guile.m4 (100%)
     rename pre-inst-guile-env.in => meta/uninstalled-env.in (87%)

The patches fix distcheck again, but the interesting one is
ec900eacb71bbf66b85a5605f67f83b43f2c6ca8, which does this in debug.c:

    @@ -513,11 +518,42 @@ SCM_DEFINE (scm_debug_hang, "debug-hang", 0, 1, 0,
     #undef FUNC_NAME
     #endif
     
    +static void
    +init_stack_limit (void)
    +{
    +#ifdef HAVE_GETRLIMIT
    +  struct rlimit lim;
    +  if (getrlimit (RLIMIT_STACK, &lim) == 0)
    +      {
    +        int bytes = lim.rlim_cur, words;
    +
    +        /* set our internal stack limit to 1 MB or 80% of the rlimit, whichever
    +           is lower. */
    +        if (bytes == RLIM_INFINITY)
    +          bytes = lim.rlim_max;
    +
    +        if (bytes == RLIM_INFINITY)
    +          words = 1024 * 1024 / sizeof (scm_t_bits);
    +        else
    +          {
    +            bytes = bytes * 8 / 10;
    +            if (bytes > 1024 * 1024)
    +              bytes = 1024 * 1024;
    +            words = bytes / sizeof (scm_t_bits);
    +          }
    +
    +        SCM_STACK_LIMIT = words;
    +      }
    +  errno = 0;
    +#endif
    +}
    +
     \f
     
     void
     scm_init_debug ()
     {
    +  init_stack_limit ();
       scm_init_opts (scm_debug_options, scm_debug_opts);
    [...]

Comments? OK to merge to master?

Andy
-- 
http://wingolog.org/




             reply	other threads:[~2009-03-27 23:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-27 23:29 Andy Wingo [this message]
2009-03-29  6:20 ` request review: branch "wingo" Andy Wingo
2009-03-29 21:16   ` Neil Jerram
2009-03-30 21:39   ` Neil Jerram
2009-03-31  3:31     ` Andy Wingo
2009-03-31 23:25       ` Neil Jerram
2009-04-01  7:49         ` Ludovic Courtès
2009-04-01 13:46           ` Greg Troxel
2009-04-01 22:23           ` Neil Jerram
2009-04-03 17:24             ` Andy Wingo
2009-04-03 17:51         ` Andy Wingo
2009-04-12 13:00           ` Neil Jerram
2009-03-31 16:38   ` Ludovic Courtès
2009-03-31 19:11     ` Andy Wingo
2009-03-31 21:31       ` Ludovic Courtès
2009-03-31 22:47         ` Andy Wingo
2009-04-01  7:51           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hc1esfws.fsf@pobox.com \
    --to=wingo@pobox.com \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).