unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: No Itisnt <theseaisinhere@gmail.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: Build problem & unrelated patch
Date: Sun, 06 Jun 2010 21:41:23 +0200	[thread overview]
Message-ID: <m3fx10uexo.fsf@pobox.com> (raw)
In-Reply-To: <AANLkTilwznDVkbaxv0LVo1EwB7I2Qp3E24wqWYpe0kLe@mail.gmail.com> (No Itisnt's message of "Thu, 3 Jun 2010 23:37:12 -0500")

On Fri 04 Jun 2010 06:37, No Itisnt <theseaisinhere@gmail.com> writes:

>> Here is a patch that uses AM_SILENT_RULES
>> (http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html) to
>> pare down build output, and also adds some files to .gitignore. I
>> think it's a good idea.

Given that Ludovic is OK with it, and I would like to be able to do
silent rules, cool. Please repost as git commits via git-format-patch,
so we get changelogs. Some comments:

> --- a/.gitignore
> +++ b/.gitignore
> +.#*

When do you get these?

> +/lib/c++defs.h
> +/lib/iconv.h
> +/lib/netdb.h

I don't see these in my tree

> +/module/ice-9/psyntax-pp.go.*

This is a temp file, if you have it it's junk and you have to delete
manually. Not appropriate for .gitignore IMO

> +++ b/am/guilec
> @@ -30,8 +30,15 @@ install-data-hook:
>  	  touch -r "$$d$$p" "$(DESTDIR)$(ccachedir)/$$f"; \
>  	done
>  
> +
> +GUILE_SNARF = $(top_builddir)/libguile/guile-snarf

Why GUILE_SNARF here? Shouldn't that be in am/snarf ?

The rest looks fine to me :)

Andy
-- 
http://wingolog.org/



  reply	other threads:[~2010-06-06 19:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04  1:45 Build problem & unrelated patch No Itisnt
2010-06-04  4:37 ` No Itisnt
2010-06-06 19:41   ` Andy Wingo [this message]
2010-06-06 21:37     ` No Itisnt
2010-06-08 21:27       ` Ludovic Courtès
2010-06-17 15:30       ` No Itisnt
2010-06-06 14:13 ` Ludovic Courtès
2010-06-06 20:42 ` Ludovic Courtès
2010-06-06 22:44   ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fx10uexo.fsf@pobox.com \
    --to=wingo@pobox.com \
    --cc=guile-devel@gnu.org \
    --cc=theseaisinhere@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).