From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCHES] various commenting, whitespace changes Date: Fri, 27 Aug 2010 08:16:33 -0700 Message-ID: References: <87bpazfgsq.fsf@ambire.localdomain> <8762yw8nn5.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1282922025 29103 80.91.229.12 (27 Aug 2010 15:13:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 27 Aug 2010 15:13:45 +0000 (UTC) Cc: guile-devel@gnu.org To: Thien-Thi Nguyen Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Aug 27 17:13:44 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Op0ch-00087d-UP for guile-devel@m.gmane.org; Fri, 27 Aug 2010 17:13:44 +0200 Original-Received: from localhost ([127.0.0.1]:48334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Op0cc-0001Q8-NQ for guile-devel@m.gmane.org; Fri, 27 Aug 2010 11:13:38 -0400 Original-Received: from [140.186.70.92] (port=34496 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Op0cR-0001L0-11 for guile-devel@gnu.org; Fri, 27 Aug 2010 11:13:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Op0cL-0007WQ-TY for guile-devel@gnu.org; Fri, 27 Aug 2010 11:13:26 -0400 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:42803 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Op0cL-0007WJ-JB for guile-devel@gnu.org; Fri, 27 Aug 2010 11:13:21 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id D972BD10D2; Fri, 27 Aug 2010 11:13:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=TQxhikl6a6FY RZiFmOnt1d1Tba8=; b=mZxL3c5AXX9QhFq88XcTdSQisjqFKK7Fj9TwDLLCl+ul 7HuFV/+xgnxB6ND0UmlTQoW+USF8Yw3NDFQPFH4Ugre0rFIFZqa6EGdhCtIMJpJ0 i/FDSckYzF+nZGwtIK6QI4AMZm5gneVqO3aMCzd0RhnHPSXc2Ze9K1pE4CE4ENI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=xTccdD Z8g/uyMmew2og0bRewiVm/obxCBS5Y6lGZQo3B9ol412SJ9HLaSLrRoS4UWLMCXU KPFioqhQnuQI3UBJ7YMtGw8RgqylZcpYzX8KwitrebemfvpvD1+MTroTKH0Vpy3B h74PM/7uvxYkAJFMJHRqOLVoKKhwojACP0zes= Original-Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id C66F6D10D1; Fri, 27 Aug 2010 11:13:19 -0400 (EDT) Original-Received: from unquote.localdomain (unknown [75.28.21.123]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 102D8D10CE; Fri, 27 Aug 2010 11:13:17 -0400 (EDT) In-Reply-To: <8762yw8nn5.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Fri, 27 Aug 2010 10:29:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: A0386406-B1ED-11DF-A3C2-030CEE7EF46B-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10790 Archived-At: Hi Thien-Thi, Let me say first that I am really happy to have your energetic, experienced hand going over Guile sources. Thank you! I do think that small things are important, and your willingness to look at the small *and* the big is much appreciated. It's nice to have thoughtful, local commits. On Fri 27 Aug 2010 01:29, Thien-Thi Nguyen writes: > I will avoid general cleanup, but i don't intend to avoid cleanup on > files i wish to hack on (for now, this set includes makefiles, build > scripts and documentation). Fair enough. Please continue to separate cleanup commits from other commits. > I sidestepped [issues in guile-func-name-check], by rewriting in > Scheme (and using Emacs' =E2=80=98indent-sexp=E2=80=99). Unfortunately, = it looks like > hydra is not liking it: > > http://hydra.nixos.org/build/606792 > > Perhaps a workaround would be to use =E2=80=98--no-autocompile=E2=80=99 i= n the > invocation command (libguile/guile-snarf-docs.in:55), but that seems > ugly and throws away a bug-{hunt,squash}ing opportunity. WDYT? I think that not autocompiling is the right thing in this case. We don't actually want to autocompile in Guile when, um, compiling :) Also in the future, please run clean builds when you change invocations of guile within libguile/. Thanks :) > Another related idea: Since Guile supports many languages, why not AWK? That would be fun! Cheers, Andy --=20 http://wingolog.org/