From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: prj@po.cwru.edu (Paul Jarc) Newsgroups: gmane.lisp.guile.devel Subject: Re: setgroups Date: Mon, 21 Apr 2003 12:20:43 -0400 Organization: What did you have in mind? A short, blunt, human pyramid? Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: References: <87brz4dagq.fsf@raven.i.defaultvalue.org> <87u1cwcwcq.fsf@raven.i.defaultvalue.org> <874r4w85b6.fsf@zagadka.ping.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1050942507 2700 80.91.224.249 (21 Apr 2003 16:28:27 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Apr 2003 16:28:27 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Apr 21 18:28:23 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 197e9X-0000hB-00 for ; Mon, 21 Apr 2003 18:28:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 197eAI-0000on-01 for guile-devel@m.gmane.org; Mon, 21 Apr 2003 12:29:10 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 197e9O-0000J7-00 for guile-devel@gnu.org; Mon, 21 Apr 2003 12:28:14 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 197e9B-0000BY-00 for guile-devel@gnu.org; Mon, 21 Apr 2003 12:28:02 -0400 Original-Received: from multivac.student.cwru.edu ([129.22.114.26] helo=multivac.cwru.edu) by monty-python.gnu.org with smtp (Exim 4.10.13) id 197e90-0008E3-00 for guile-devel@gnu.org; Mon, 21 Apr 2003 12:27:50 -0400 Original-Received: (qmail 25158 invoked by uid 500); 21 Apr 2003 16:21:05 -0000 Original-To: guile-devel@gnu.org In-Reply-To: (Paul Jarc's message of "Fri, 18 Apr 2003 13:49:53 -0400") Mail-Copies-To: nobody Mail-Followup-To: guile-devel@gnu.org Original-Lines: 18 User-Agent: Gnus/5.090019 (Oort Gnus v0.19) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Developers list for Guile, the GNU extensibility library List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:2192 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:2192 I wrote: > + result = setgroups (ngroups, groups); > + free (groups); > + if (result < 0) > + SCM_SYSERROR; Should errno be saved and restored here to avoid interference from free()? The C standard says: "The value of errno may be set to nonzero by a library function call whether or not there is an error, provided the use of errno is not documented in the description of the function in this International Standard.", and the description of free() doesn't mention errno. But if we're already ignoring this issue in the rest of the code, I won't bother. (Or I'll work on a patch later to address as many instances of the problem as I can find.) paul _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel