From: Andy Wingo <wingo@pobox.com>
To: Volker Grabsch <vog@notjusthosting.com>
Cc: guile-devel@gnu.org
Subject: Re: Portability fixes for win32 cross compiling
Date: Fri, 21 May 2010 12:09:47 +0200 [thread overview]
Message-ID: <m3eih51s7o.fsf@pobox.com> (raw)
In-Reply-To: <20100421202248.GA16263@flap> (Volker Grabsch's message of "Wed, 21 Apr 2010 22:22:48 +0200")
Hi Volker,
I had your messages starred as needing attention, and was silently
hoping Ludovic would deal with them. I'm sure he did the same, but in
reverse ;-)
Your patches look good, except for one.
On Wed 21 Apr 2010 22:22, Volker Grabsch <vog@notjusthosting.com> writes:
> --- a/libguile/bdw-gc.h
> +++ b/libguile/bdw-gc.h
> @@ -34,6 +34,8 @@
>
> #endif
>
> +#define GC_NO_THREAD_REDIRECTS
> +
> #include <gc/gc.h>
Why did you do this?
In the future it will make it easier for me to apply these if they
follow our changelogging standards :) See any of the commits in Guile
for examples of the format.
Cheers,
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2010-05-21 10:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 0:51 Portability fixes for win32 cross compiling Volker Grabsch
2010-04-15 14:12 ` Mike Gran
2010-04-15 20:58 ` Volker Grabsch
2010-04-21 20:22 ` Volker Grabsch
2010-05-03 9:17 ` Volker Grabsch
2010-05-03 12:31 ` Greg Troxel
2010-05-21 10:09 ` Andy Wingo [this message]
2010-05-22 13:44 ` Ludovic Courtès
2010-05-24 20:30 ` Volker Grabsch
2010-05-28 13:10 ` Ludovic Courtès
2010-05-28 14:56 ` Volker Grabsch
2010-06-08 22:01 ` Ludovic Courtès
2010-06-08 22:12 ` No Itisnt
2010-06-09 6:42 ` Andy Wingo
2010-07-28 12:40 ` Volker Grabsch
2010-05-28 13:15 ` Ludovic Courtès
2010-05-28 14:44 ` Volker Grabsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eih51s7o.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=vog@notjusthosting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).