From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Some tweaks to the R6RS support Date: Sat, 20 Nov 2010 16:38:54 +0100 Message-ID: References: <87r5fcftwi.fsf@delenn.lan> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1290267311 5777 80.91.229.12 (20 Nov 2010 15:35:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 20 Nov 2010 15:35:11 +0000 (UTC) Cc: Guile Development To: Andreas Rottmann Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Nov 20 16:35:07 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PJpT1-0007Su-5P for guile-devel@m.gmane.org; Sat, 20 Nov 2010 16:35:07 +0100 Original-Received: from localhost ([127.0.0.1]:37790 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJpT0-0002A7-KH for guile-devel@m.gmane.org; Sat, 20 Nov 2010 10:35:06 -0500 Original-Received: from [140.186.70.92] (port=35975 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJpSv-00027z-DT for guile-devel@gnu.org; Sat, 20 Nov 2010 10:35:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJpSt-0007fE-Sy for guile-devel@gnu.org; Sat, 20 Nov 2010 10:35:01 -0500 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:65119 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJpSt-0007eD-PU for guile-devel@gnu.org; Sat, 20 Nov 2010 10:34:59 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id DC53626E0; Sat, 20 Nov 2010 10:35:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=ggLx7rH12q6BCY9iXoZvk50xYEU=; b=fv7x15 sC5JKbIrgPckAl/CqsTvZ9Q2o7vulxoN/8TqdM/1Yu/LmdVxPfdxvtow0rrt92kW T8MQNvnD4tdhgMWtXqqKhb/Kr471Bh3hPj9+0C2dAfo/0kuLJMcYPYeIWyG8PLiD iMG+4pyMT5X79UweA8oOR4NzV/2CT6e3LPuNw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=HSYjUOse1SQ1s/gLYyv/omlVgzVEjJu6 DBIV/cLlpHJb6qh4yFXUFCIi1d2ArY7HNXcUXGsHTwq976DpRpW8XNENN/CY2XOh q8mVSWdSbGuQ8+LKBbd62J3ZHJ4Z1YojhFN2Zx8qnNaaJjXDsTYqMtYsHikfuGrq 4vmdOsPznlw= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id B0E5E26DD; Sat, 20 Nov 2010 10:35:09 -0500 (EST) Original-Received: from unquote.localdomain (unknown [88.0.167.219]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id E58BF26DC; Sat, 20 Nov 2010 10:35:07 -0500 (EST) In-Reply-To: <87r5fcftwi.fsf@delenn.lan> (Andreas Rottmann's message of "Wed, 27 Oct 2010 00:53:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: C218552A-F4BB-11DF-8678-B53272ABC92C-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11159 Archived-At: Hi Andreas, On Wed 27 Oct 2010 00:53, Andreas Rottmann writes: > * module/rnrs/base.scm (error, assert): Define -- they were missing. > (assertion-violation): Properly treat a #f `who' argument. > > * module/rnrs/conditions.scm (condition): Use `assertion-violation' > instead of the undefined `raise'. > (define-condition-type): Fix for multiple fields. > * test-suite/tests/r6rs-conditions.test: Test accessors of a > multiple-field condition. Also import `(rnrs base)' to allow > stand-alone running of the tests; apparently the `@' references > scattered throughout the R6RS modules make the libraries sensitive to > their load order -- for instance, trying to load `(rnrs conditions)' > before `(rnrs base)' is loaded fails. > > * module/rnrs/records/inspection.scm: Use `assertion-violation' instead > of an explicit `raise'. > * module/rnrs/records/syntactic.scm (process-fields): Use > `syntax-violation' instead of bogus invocations of `error'. This patch no longer applies. Apologies for the delay. Can you take a look at which parts are still valid? Thanks, Andy -- http://wingolog.org/