From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. 442f3f20ddd33b43743ea181d95024c10622df52 Date: Tue, 26 May 2009 22:31:17 +0200 Message-ID: References: <871vqbkcx1.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1243370734 10194 80.91.229.12 (26 May 2009 20:45:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 May 2009 20:45:34 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue May 26 22:45:28 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M93WW-0001Rr-H1 for guile-devel@m.gmane.org; Tue, 26 May 2009 22:45:25 +0200 Original-Received: from localhost ([127.0.0.1]:53390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M93WW-0000oq-1c for guile-devel@m.gmane.org; Tue, 26 May 2009 16:45:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M93WI-0000kf-Bj for guile-devel@gnu.org; Tue, 26 May 2009 16:45:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M93WD-0000gh-O1 for guile-devel@gnu.org; Tue, 26 May 2009 16:45:10 -0400 Original-Received: from [199.232.76.173] (port=50700 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M93WD-0000gU-Kv for guile-devel@gnu.org; Tue, 26 May 2009 16:45:05 -0400 Original-Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:54185 helo=sasl.smtp.pobox.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M93W9-0008Mv-FF; Tue, 26 May 2009 16:45:01 -0400 Original-Received: from localhost.localdomain (unknown [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 8EBFDB612F; Tue, 26 May 2009 16:45:00 -0400 (EDT) Original-Received: from unquote (unknown [83.44.191.123]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 1EA3FB612E; Tue, 26 May 2009 16:44:57 -0400 (EDT) In-Reply-To: <871vqbkcx1.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 26 May 2009 19:10:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) X-Pobox-Relay-ID: 14CEB5A2-4A36-11DE-9E95-F6BA321C86B1-02397024!a-sasl-fastnet.pobox.com X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8524 Archived-At: Heya Ludo, On Tue 26 May 2009 19:10, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > "Andy Wingo" writes: > >> +#if BUILDING_LIBGUILE && HAVE_VISIBILITY >> +# define SCM_API extern __attribute__((__visibility__("default"))) >> +#elif BUILDING_LIBGUILE && defined _MSC_VER > > This should be: > > #if defined BUILDING_LIBGUILE && BUILDING_LIBGUILE && HAVE_VISIBILITY I believe that this is strictly equivalent. Quoth the CPP manual: #if expression =20=20=20=20=20 controlled text =20=20=20=20=20 #endif /* expression */ expression is a C expression of integer type, subject to stringent restrict= ions. It may contain * Integer constants. * Character constants ... * Arithmetic operators ... * Macros ... * Uses of the defined operator ... * Identifiers that are not macros, which are all considered to be the number zero. This allows you to write #if MACRO instead of #ifdef MACRO, if you know that MACRO, when defined, will always have a nonzero value. Function-like macros used without their function call parentheses are also treated as zero. In some contexts this shortcut is undesirable. The -Wundef option causes GCC to warn whenever it encounters an identifier which is not a macro in an `#if'. But I guess that we want to support -Wundef or something, and this is in a public header, so I suppose you are right :) > Also, I'd have preferred `_GUILE_WITHIN_GUILE', which is clearly in > Guile's name space, and is similar to GMP's `__GMP_WITHIN_GMP' ("rule of > least surprise"). What do you think? I don't care :) I thought I recalled that Neil wanted something else, and Bruno had this in the gnulib docs, so I just used that. Please tell me to change it if you want it changed :-) Cheers, Andy --=20 http://wingolog.org/