From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-6-75-g9c246c0 Date: Wed, 06 Jan 2010 11:13:37 +0100 Message-ID: References: <87r5q48mfg.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1262775541 5933 80.91.229.12 (6 Jan 2010 10:59:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2010 10:59:01 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Jan 06 11:58:53 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NSTam-0005mW-S5 for guile-devel@m.gmane.org; Wed, 06 Jan 2010 11:58:21 +0100 Original-Received: from localhost ([127.0.0.1]:34750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSTan-000755-FK for guile-devel@m.gmane.org; Wed, 06 Jan 2010 05:58:21 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSTag-000734-5U for guile-devel@gnu.org; Wed, 06 Jan 2010 05:58:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSTab-0006yo-4h for guile-devel@gnu.org; Wed, 06 Jan 2010 05:58:13 -0500 Original-Received: from [199.232.76.173] (port=57799 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSTaa-0006yN-P1 for guile-devel@gnu.org; Wed, 06 Jan 2010 05:58:08 -0500 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:60401 helo=sasl.smtp.pobox.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NSTaY-0004Et-FP; Wed, 06 Jan 2010 05:58:06 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 6F4F98D9A8; Wed, 6 Jan 2010 05:58:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=n2tn5V7KV/o7 a3SsKyZjwIYAGik=; b=ZwjecF4zuV8PDYDuXv9XA0MrLkZBxNVbsJEMTEt/eDg3 DUMuGCHTAwADMGd3o7PDHNSMiLVoRshuyVYw+DkuIoiIdgLFViaLV3U5imuZ4678 DU0HqAXZte/zFdkFcRINA+BR8DhBvRJ8ysjPjZk7fNIl/C0CirZQQ5mOy1eoO3s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=Twbpva xWnAL/PwdSCZrGkELBVQYdgZxgJRTXaAttZSub5azfqEjEoAxBTvF06TGVU7bPqK iD/J2/pJ/rQAKlQP/rvyvkuvWHFhHKlJ9JXwSqSmUhUZ2ifqsE3a/7O9BfdAfF5Q fbukM1OoqS4EzF1Io0T+EwyoJoUeGUXzWkH7k= Original-Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 539798D9A6; Wed, 6 Jan 2010 05:58:04 -0500 (EST) Original-Received: from unquote (unknown [83.202.29.76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 8481D8D9A4; Wed, 6 Jan 2010 05:58:02 -0500 (EST) In-Reply-To: <87r5q48mfg.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 05 Jan 2010 18:57:07 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) X-Pobox-Relay-ID: 5D3B994A-FAB2-11DE-8043-9D59EE7EF46B-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9830 Archived-At: Heya, On Tue 05 Jan 2010 18:57, ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> commit 9fdf9fd3ea7130fd85eaf0a333a965ac4d2b07c3 >> Author: Andy Wingo >> Date: Tue Jan 5 16:15:14 2010 +0100 >> >> move subr implementation details to gsubr.[ch] >>=20=20=20=20=20 >> * libguile/procs.h: Move subr macros to gsubr.h. >> * libguile/procs.c (scm_c_make_subr, scm_c_make_subr_with_generic) >> (scm_c_define_subr, scm_c_define_subr_with_generic): Remove these, >> because they deal in subr types, and now there is only one subr ty= pe. > > This is slightly scary, because these were really-public functions, but > I guess there=E2=80=99s no other choice anyway (and fundamentally I think= this > change is going in the Right Direction!). Yeah, agreed in both sentiments. >> +/* Deprecated 2010-01-05, use SCM_PRIMITIVE_P instead */ >> +#define scm_subr_p(x) (SCM_PRIMITIVE_P (x)) > > Can you change it so it generates a link-time and run-time warning? > See, e.g., =E2=80=98scm_mask_ints=E2=80=99. Done (locally). >> +/* Return the most suitable subr type for a subr with REQ required argu= ments, >> + OPT optional arguments, and REST (0 or 1) arguments. This has to be= in >> + sync with `create_gsubr ()'. */ >> +#define SCM_SUBR_ARITY_TO_TYPE(req, opt, rest) \ >> + (scm_tc7_gsubr | (SCM_GSUBR_MAKTYPE (req, opt, rest) << 8U)) > > =E2=80=9CMost suitable=E2=80=9D and the second sentence can be removed no= w. I hope to remove the whole thing. I have a bytecode-subrs branch that doesn't quite work yet, but hopefully will work today. Cheers, Andy --=20 http://wingolog.org/