From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-8-23-gea6b18e Date: Sat, 17 Jul 2010 12:12:13 +0200 Message-ID: References: <874ol12gj7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1279361387 12835 80.91.229.12 (17 Jul 2010 10:09:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 17 Jul 2010 10:09:47 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Jul 17 12:09:46 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oa4L1-0004PP-04 for guile-devel@m.gmane.org; Sat, 17 Jul 2010 12:09:43 +0200 Original-Received: from localhost ([127.0.0.1]:51123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oa4Kz-0002dE-Ql for guile-devel@m.gmane.org; Sat, 17 Jul 2010 06:09:41 -0400 Original-Received: from [140.186.70.92] (port=33734 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oa4Kq-0002cr-Sf for guile-devel@gnu.org; Sat, 17 Jul 2010 06:09:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oa4Ko-0003oi-2R for guile-devel@gnu.org; Sat, 17 Jul 2010 06:09:31 -0400 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:46358 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oa4Kn-0003oc-Vb; Sat, 17 Jul 2010 06:09:30 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 6B1AEC5047; Sat, 17 Jul 2010 06:09:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=sZCWRKihXIZZ OzCCfYjIVjw0bL4=; b=B338T7Q9cO8q0nf5scLm6aKq0q7rfgdHxnVwSk2Av1n1 VYHgP32gU44t2yzyNL6EgsbTYeGu1T9X8tZdQU/iZpoOgNaLVz6PiMirBCW/8m3+ zPA8hueACDLTvHNFcOMttZ5+L6CWgY2NePGxmec2dWhW4JnDgM+FVWXFSYIARrI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=lxuqNx 9JseNrmvTG8MVyNQxwbssaxmSqV18N/YIctHJEV7ryRmvi3iM998gcn7YyGYWSfS EN8LveZBrc5fyp7SpC6Iqh2btj/UVzT97XJfhlblS5Td/wUmMmur5IbFdv7tyKVZ nxPoHeabDuzwL2SucuIcdKM12AuKDkvbE7Fo4= Original-Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 5875EC5046; Sat, 17 Jul 2010 06:09:28 -0400 (EDT) Original-Received: from unquote.localdomain (unknown [81.38.186.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 8F80EC5045; Sat, 17 Jul 2010 06:09:26 -0400 (EDT) In-Reply-To: <874ol12gj7.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 28 Feb 2010 22:31:56 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: 627EBADE-918B-11DF-8144-9056EE7EF46B-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10672 Archived-At: Heya, On Sun 28 Feb 2010 22:31, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > (Sorry for the late & light review...) Sorry for the late & light reply :) >> +#define SCM_I_FLUID_P(x) (!SCM_IMP (x) && SCM_TYP7 (x) =3D=3D = scm_tc7_fluid) > > How about renaming it to =E2=80=98SCM_FLUID_P=E2=80=99 and making it publ= ic? Done >> +#define SCM_I_FLUID_NUM(x) ((size_t)SCM_CELL_WORD_1(x)) > > Could be in #ifdef BUILDING_LIBGUILE? Done >> diff --git a/libguile/vm-engine.c b/libguile/vm-engine.c >> index 75dd613..5d1e1d6 100644 >> --- a/libguile/vm-engine.c >> +++ b/libguile/vm-engine.c >> @@ -47,6 +47,7 @@ VM_NAME (SCM vm, SCM program, SCM *argv, int nargs) >> SCM *objects =3D NULL; /* constant objects */ >> size_t object_count =3D 0; /* length of OBJECTS */ >> SCM *stack_limit =3D vp->stack_limit; /* stack limit address */ >> + SCM dynstate =3D SCM_I_CURRENT_THREAD->dynamic_state; > > Out of curiosity, what effect does this have on performance? Dunno! >> + ( fluid) >> + ( fluid exp) > > At first sight =E2=80=98fluid-ref=E2=80=99 and =E2=80=98fluid-set=E2=80= =99 would seem more natural names > to me. What do you think? I had it like that before, but I did it this way to match dynwind and dynle= t. Andy --=20 http://wingolog.org/