From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Allow printing of malformed tree-il Date: Sat, 17 Jul 2010 14:11:04 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279368516 12312 80.91.229.12 (17 Jul 2010 12:08:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 17 Jul 2010 12:08:36 +0000 (UTC) Cc: guile-devel To: No Itisnt Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Jul 17 14:08:34 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oa6Bz-0005pu-KF for guile-devel@m.gmane.org; Sat, 17 Jul 2010 14:08:31 +0200 Original-Received: from localhost ([127.0.0.1]:47131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oa6By-0002gK-LM for guile-devel@m.gmane.org; Sat, 17 Jul 2010 08:08:30 -0400 Original-Received: from [140.186.70.92] (port=53936 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oa6Bs-0002gB-4P for guile-devel@gnu.org; Sat, 17 Jul 2010 08:08:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oa6Bq-00025M-8m for guile-devel@gnu.org; Sat, 17 Jul 2010 08:08:23 -0400 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:63148 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oa6Bq-00025E-2f for guile-devel@gnu.org; Sat, 17 Jul 2010 08:08:22 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 2071BC58E0; Sat, 17 Jul 2010 08:08:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=J78oH1sammgimKzz4LhmRDY4eWY=; b=yYvy3m PRQiUeNxcyT5+f9tgWy2PmaDLUFRFG3VFD43oAxgb6S94WE62EsVDB5R+dfsMsq4 3pXVO4deLk2xVG8LPzmXQ4pyfnunblp9dNqkDlyXBp/Ga6/7APX/DHNBQJh2pkJC Y9xGctEs/m83ppqaHEzKpxssLtfrYWzqi1VEI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=b0eJVTDi3PMBiuXbG8TbrtcrYz9JouMc eMrb1K9D8KC75sBsBAI8g5Bwb6HgdPQuxkuPniKcxy7Q8LZYI2ak0s4J8gZZLr9+ tDe25fY2aSrLVc+qENahT2/WUUGMWCLHBrbzC/zTS2TH2Ua8K4F0c4HMhThHcmWC PkJlvLUh3UE= Original-Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id F173AC58DF; Sat, 17 Jul 2010 08:08:19 -0400 (EDT) Original-Received: from unquote.localdomain (unknown [81.38.186.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 4B0F0C58DD; Sat, 17 Jul 2010 08:08:18 -0400 (EDT) In-Reply-To: (No Itisnt's message of "Fri, 9 Jul 2010 01:23:36 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: FD464C3E-919B-11DF-905E-9056EE7EF46B-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10678 Archived-At: On Fri 09 Jul 2010 08:23, No Itisnt writes: >> Looks good; a couple of comments inline. If you want to kill trailing >> whitespace, though, please do that as a separate commit, without any >> functional changes > > How do you reconcile that with 'delete-trailing-whitespace? I don't, really. I don't use that mode. It's better to respect the original source, so that the diffs and annotations aren't just noise... Of course if you trawl through *my* commits, you would find counter-examples to this "principle", so I guess there's a trade-off? >> Here we should produce a warning, I think, even if we are >> "permissive". Also please move the trailing parens to the previous >> line. > > Is there a standard way to do this? Presumably it will be printed on > *current-warning-port*, but any specific formatting guidelines or > anything? Unfortunately no guidelines, no. If you make some up, we'll use them though :) Andy -- http://wingolog.org/