From: Andy Wingo <wingo@pobox.com>
To: No Itisnt <theseaisinhere@gmail.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] Allow printing of malformed tree-il
Date: Sat, 17 Jul 2010 14:11:04 +0200 [thread overview]
Message-ID: <m38w5a2trb.fsf@unquote.localdomain> (raw)
In-Reply-To: <AANLkTikmCj-ADNI0rWDGa9T3_Zr3qQ9zss9nVE_7gRPw@mail.gmail.com> (No Itisnt's message of "Fri, 9 Jul 2010 01:23:36 -0500")
On Fri 09 Jul 2010 08:23, No Itisnt <theseaisinhere@gmail.com> writes:
>> Looks good; a couple of comments inline. If you want to kill trailing
>> whitespace, though, please do that as a separate commit, without any
>> functional changes
>
> How do you reconcile that with 'delete-trailing-whitespace?
I don't, really. I don't use that mode. It's better to respect the
original source, so that the diffs and annotations aren't just noise...
Of course if you trawl through *my* commits, you would find
counter-examples to this "principle", so I guess there's a trade-off?
>> Here we should produce a warning, I think, even if we are
>> "permissive". Also please move the trailing parens to the previous
>> line.
>
> Is there a standard way to do this? Presumably it will be printed on
> *current-warning-port*, but any specific formatting guidelines or
> anything?
Unfortunately no guidelines, no. If you make some up, we'll use them
though :)
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2010-07-17 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 0:32 [PATCH] Allow printing of malformed tree-il No Itisnt
2010-07-08 10:16 ` Andy Wingo
2010-07-09 6:23 ` No Itisnt
2010-07-17 12:11 ` Andy Wingo [this message]
2010-07-17 19:25 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38w5a2trb.fsf@unquote.localdomain \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=theseaisinhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).