unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: Thien-Thi Nguyen <ttn@gnuvola.org>
Cc: guile-devel@gnu.org
Subject: Re: rfc: [build] Overhaul <errno.h>, <signal.h> cpp symbol extraction/checking.
Date: Mon, 28 Jun 2010 15:09:19 +0200	[thread overview]
Message-ID: <m37hljz4lc.fsf@unquote.localdomain> (raw)
In-Reply-To: <87ocezfh8n.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Fri, 25 Jun 2010 14:07:20 +0200")

Hi Thien-Thi,

On Fri 25 Jun 2010 14:07, Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> () Andy Wingo <wingo@pobox.com>
> () Fri, 18 Jun 2010 10:43:07 +0200
>
>    Would you mind sending patches using git-format-patch? It's easier to
>    reply inline that way :-)
>
> Ah, ok.  I was under the impression that the preferred way was to post
> a link (to a commit) so that whoever wants to pull can do so, thus
> avoiding big email messages.  Isn't that the "git way"?

I guess there are many git ways :) Linux uses both, I think. For review
purposes though, inline mails work best for me. I'm happy to change if
there is a better way.

>    I don't really understand this patch, or the current makefile foo thb,
>    and would appreciate an explanation.
>
> I've just pushed ‘ttn/janitor’ (and deleted ‘ttn/misc-maint’), including
> the patch below, reformulated (slightly) to add a bit of explanation to
> libguile/Makefile.am.  Does that help?  I omit explaining the old way
> there, but here's a summary: "essentially (the basic approach) like the
> new way , but with more state (files, temporary and permanent) and with
> unnecessary modularity".

Ah, thank you for this explanation, and that inline to the patch. Feel
free to push this patch to master.

Cheers,

Andy
-- 
http://wingolog.org/



      reply	other threads:[~2010-06-28 13:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 15:02 rfc: [build] Overhaul <errno.h>, <signal.h> cpp symbol extraction/checking Thien-Thi Nguyen
2010-06-18  8:43 ` Andy Wingo
2010-06-25 12:07   ` Thien-Thi Nguyen
2010-06-28 13:09     ` Andy Wingo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37hljz4lc.fsf@unquote.localdomain \
    --to=wingo@pobox.com \
    --cc=guile-devel@gnu.org \
    --cc=ttn@gnuvola.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).