From: Andy Wingo <wingo@pobox.com>
To: Andreas Rottmann <a.rottmann@gmx.at>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Support for SRFI 27
Date: Sat, 28 Aug 2010 10:15:15 -0700 [thread overview]
Message-ID: <m37hja4q1o.fsf@unquote.localdomain> (raw)
In-Reply-To: <877hjrudo6.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sun, 15 Aug 2010 16:57:13 +0200")
On Sun 15 Aug 2010 07:57, ludo@gnu.org (Ludovic Courtès) writes:
> Hello!
>
> Andreas Rottmann <a.rottmann@gmx.at> writes:
>
>> Attached is my take on adding SRFI 27 "Sources of Random Bits".
>
> Nice! Looks good to me. Could you also add a node to
> doc/ref/srfi-modules.texi?
Yes, looks quite good to me!
Just a friendly ping to write some docs :)
>> +;; These tests are commented out since it /could/ happen that
>> +;; `random-source-randomize!' (or `random-source-pseudo-randomize!') puts the
>> +;; RNG into a state where it generates the same number as before. If you run
>> +;; them manually, they should have a very high chance of passing, though.
>
> Perhaps you could run them anyway and throw 'unresolved when they appear
> to fail? The guardian tests do that when it’s impossible to determine
> whether it’s a failure or whether some unrelated phenomenon prevented
> the test to pass.
Agreed.
Cheers,
Andy
--
http://wingolog.org/
prev parent reply other threads:[~2010-08-28 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 15:55 [PATCH] Support for SRFI 27 Andreas Rottmann
2010-08-15 14:57 ` Ludovic Courtès
2010-08-28 17:15 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37hja4q1o.fsf@unquote.localdomain \
--to=wingo@pobox.com \
--cc=a.rottmann@gmx.at \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).