From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, syncase-in-boot-9, updated. e3c5df539640a36eb1493f581087d54a4714f337 Date: Sun, 31 May 2009 14:14:01 +0200 Message-ID: References: <8763fip2sf.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1243777286 25350 80.91.229.12 (31 May 2009 13:41:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 May 2009 13:41:26 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun May 31 15:41:23 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MAlHa-00036i-W3 for guile-devel@m.gmane.org; Sun, 31 May 2009 15:41:22 +0200 Original-Received: from localhost ([127.0.0.1]:55192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MAlHX-0006UJ-OE for guile-devel@m.gmane.org; Sun, 31 May 2009 09:40:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MAlD9-000597-QX for guile-devel@gnu.org; Sun, 31 May 2009 09:36:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MAlD5-000570-5s for guile-devel@gnu.org; Sun, 31 May 2009 09:36:27 -0400 Original-Received: from [199.232.76.173] (port=48234 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MAlD5-00056x-1L for guile-devel@gnu.org; Sun, 31 May 2009 09:36:23 -0400 Original-Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:52123 helo=sasl.smtp.pobox.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MAlD1-0000tS-6n; Sun, 31 May 2009 09:36:19 -0400 Original-Received: from localhost.localdomain (unknown [127.0.0.1]) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTP id 954971A6E8; Sun, 31 May 2009 09:36:18 -0400 (EDT) Original-Received: from unquote (unknown [82.123.44.81]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 09EB61A6E7; Sun, 31 May 2009 09:36:16 -0400 (EDT) In-Reply-To: <8763fip2sf.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 31 May 2009 01:52:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) X-Pobox-Relay-ID: 0565C0C8-4DE8-11DE-9243-B4FDD46C8AFF-02397024!a-sasl-quonix.pobox.com X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8581 Archived-At: Howdy, Thanks for the review! On Sun 31 May 2009 01:52, ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> commit 34f3d47df9311852ba7eab6f8d1c36535c3774dd >> Author: Andy Wingo >> Date: Thu May 28 14:49:33 2009 +0200 > > [...] > >> * module/ice-9/boot-9.scm: Remove #' read-hash extension, which actu= ally >> didn't do anything at all. It's been there since 1997, but no Guile >> code I've ever seen uses it, and it conflicts with #'x =3D> (synta= x x) >> from modern Scheme. > > I find this point questionable. Do we really need to break this > functionality? It would be nicer if we could both keep > `read-hash-extend' and the functionality you want. What do you think? `read-hash-extend' is still there. This just removed the #' read-hash-extension, which was the identity extension: #'foo =3D=3D foo. `read-hash-extend' overrides any core hash forms, so this extension prevented #'foo =3D=3D (syntax foo). It would be easy for an affected reader to add this particular extension back, though. > (Besides, this commit appears to contain unrelated changes. They are all described by the commit log, right? It is true that some of the changes are not related to others, though. I'll try to separate them out more in the future. > Also, I > prefer it when the test case appears in the same commit as the feature > it tests, for easier review.) OK. > You may also want to add "SRFI-62 support" in `NEWS'. Yes, and to the cond-expand forms. I have a lot of things I need to add to NEWS before the release. Cheers, Andy --=20 http://wingolog.org/