unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: Trouble joining with threads from C
Date: Fri, 15 Apr 2011 10:41:42 +0200	[thread overview]
Message-ID: <m362qflxdl.fsf@unquote.localdomain> (raw)
In-Reply-To: <877haxzvh6.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 13 Apr 2011 23:34:29 +0200")

Hi Ludovic,

On Wed 13 Apr 2011 23:34, ludo@gnu.org (Ludovic Courtès) writes:

> After reviewing f60a7648d5926555c7760364a6fbb7dc0cf60720 (which
> addressed the same issue), I lean towards reverting it and instead
> applying the patch I just sent.
>
> The problem I see with f60a7648d5926555c7760364a6fbb7dc0cf60720 is that
> it re-introduces a pthread_key, even when using TLS, and make things a
> bit complex IMO.

The issue is that threads in Guile are not always spawned by Guile.
It's true that of the two cases in which Guile spawned a thread, one of
them wasn't getting the cleanup handlers called, and your patch fixes
that; but that ignores the case of threads that are spawned by a user's
program.

For example in the following program:

    void* thread (void*)
    {
      scm_with_guile (do_something, NULL);
      scm_with_guile (do_something_else, NULL);
      return NULL;
    }

    int main ()
    {
      pthread_t thr;
      pthread_create (&thr, NULL, thread, NULL);
      pthread_join (thr, NULL);
      return 0;
    }

When do you propose that the cleanup handlers for the thread be called?

As far as I understand things, reliably cleaning up after the thread
*requires* the use of pthread_key with a destructor.  It is the only way
to attach a cleanup callback to a thread.  It's true that the key is not
used when TLS is available, except for its destructor capabilities, but
it is not more complicated than before.

I think they context that you are missing here is bug 32436.

It does appear that I have introduced some bugs here: Mark's
after-gc-hook not being called, and a failure to build
--without-threads.  For that I apologize.  But these bugs are fixable.
Consider bug 32436 for a moment: you can't fix that with
pthread_cleanup_push.

Does this explanation help?

Let me know,

Andy
-- 
http://wingolog.org/



  reply	other threads:[~2011-04-15  8:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07  5:56 Trouble joining with threads from C Mark H Weaver
2011-03-09  6:48 ` Mark H Weaver
2011-03-18 12:23   ` Andy Wingo
2011-03-20 23:11     ` Ludovic Courtès
2011-04-13 21:25       ` Ludovic Courtès
2011-04-13 21:34         ` Ludovic Courtès
2011-04-15  8:41           ` Andy Wingo [this message]
2011-04-15 21:44             ` Ludovic Courtès
2011-04-16 15:55               ` Andy Wingo
2011-04-25 13:53             ` Ludovic Courtès
2011-04-25 14:19               ` Andy Wingo
2011-04-25 14:49                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m362qflxdl.fsf@unquote.localdomain \
    --to=wingo@pobox.com \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).