From: Andy Wingo <wingo@pobox.com>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: Set debug output width in REPL
Date: Sat, 05 Mar 2011 20:01:56 +0100 [thread overview]
Message-ID: <m34o7he6hn.fsf@unquote.localdomain> (raw)
In-Reply-To: <8739n1d7gs.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sat, 05 Mar 2011 14:26:11 +0100")
On Sat 05 Mar 2011 14:26, ludo@gnu.org (Ludovic Courtès) writes:
> Andy Wingo <wingo@pobox.com> writes:
>
>> On Mon 21 Feb 2011 07:02, Mike Gran <spk121@yahoo.com> writes:
>>
>>> I find that the backtrace output in the REPL is too constrained
>>> my verbose code. The attached patch would let one set the
>>>
>>> width of the backtrace and locals meta-commands.
>>>
>>> What do you think?
>>
>> Applied, thanks.
>
> FWIW I still think that the default should take into account terminal
> settings, as discussed in this thread.
Sorry for the confusion. The terminal settings are associated with an
fd, which maps more or less to a port, and I thought that you were
opposed to port-specific properties. (Incidentally I did not think that
argument made much sense.)
Having it be a repl-specific property has the irritation of propagating
the width down to nested repls. To me the true place of this setting
is specific to a thread, as repls are (largely) specific to threads.
So it would be equivalent to have `terminal-width' close over a fluid
instead of a lexical.
Anyway, with a week gone by and no more patches from anyone involved, I
decided to think about it myself for a bit, and ended up thinking Mike's
patch was "worse is better", but then also feeling it could be cleaner,
hence my addition.
Also, I wanted the initial settings to reflect the terminal width
without a need to call ,width.
So them's the reasons! Let me know if you have any more concerns. Do
try out different approaches -- it is a clarifying agent :)
Regards,
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2011-03-05 19:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 6:02 Set debug output width in REPL Mike Gran
2011-02-21 16:12 ` Mark H Weaver
2011-02-21 16:36 ` Mark H Weaver
2011-03-04 10:17 ` Andy Wingo
2011-03-05 13:26 ` Ludovic Courtès
2011-03-05 19:01 ` Andy Wingo [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-21 22:55 Mike Gran
2011-02-24 23:28 ` Ludovic Courtès
2011-02-26 9:17 ` Mark H Weaver
2011-03-05 19:18 ` Mark H Weaver
2011-02-25 1:43 Mike Gran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34o7he6hn.fsf@unquote.localdomain \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).