* [PATCH] Update comment about uc_locale_language
@ 2011-03-26 15:51 Bruno Haible
2011-03-26 22:34 ` Andy Wingo
0 siblings, 1 reply; 2+ messages in thread
From: Bruno Haible @ 2011-03-26 15:51 UTC (permalink / raw)
To: guile-devel
Hi,
The comment about uc_locale_language is outdated. Please consider this patch
(to be applied with "patch -p0").
2011-03-26 Bruno Haible <bruno@clisp.org>
Update comment about uc_locale_language.
* libguile/i18n.c (locale_language): Update comment.
--- libguile/i18n.c.orig Sat Mar 26 16:40:28 2011
+++ libguile/i18n.c Sat Mar 26 16:34:55 2011
@@ -766,16 +766,11 @@
static const char *
locale_language ()
{
- /* FIXME: If the locale has been set with 'uselocale',
- libunistring's uc_locale_language will return the incorrect
+ /* Note: If the locale has been set with 'uselocale', uc_locale_language
+ from libunistring versions 0.9.1 and older will return the incorrect
language: it will return the language appropriate for the global
- (non-thread-specific) locale.
-
- There appears to be no portable way to extract the language from
- the thread-specific locale_t. There is no LANGUAGE capability in
- nl_langinfo or nl_langinfo_l.
-
- Thus, uc_locale_language needs to be fixed upstream. */
+ (non-thread-specific) locale. This is fixed in versions 0.9.2 and
+ newer. */
return uc_locale_language ();
}
--
In memoriam Joseph Carlebach <http://en.wikipedia.org/wiki/Joseph_Carlebach>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Update comment about uc_locale_language
2011-03-26 15:51 [PATCH] Update comment about uc_locale_language Bruno Haible
@ 2011-03-26 22:34 ` Andy Wingo
0 siblings, 0 replies; 2+ messages in thread
From: Andy Wingo @ 2011-03-26 22:34 UTC (permalink / raw)
To: Bruno Haible; +Cc: guile-devel
On Sat 26 Mar 2011 16:51, Bruno Haible <bruno@clisp.org> writes:
> The comment about uc_locale_language is outdated. Please consider this patch
> (to be applied with "patch -p0").
Applied. Thanks!
Andy
--
http://wingolog.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-26 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-26 15:51 [PATCH] Update comment about uc_locale_language Bruno Haible
2011-03-26 22:34 ` Andy Wingo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).