unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: Neil Jerram <neil@ossau.uklinux.net>
Cc: guile-devel@gnu.org
Subject: Re: Queries about while doc and (ice-9 command-line)
Date: Thu, 28 Apr 2011 21:47:40 +0200	[thread overview]
Message-ID: <m339l217kz.fsf@unquote.localdomain> (raw)
In-Reply-To: <877haemehv.fsf@ossau.uklinux.net> (Neil Jerram's message of "Thu, 28 Apr 2011 19:12:44 +0100")

Hi Neil,

Thanks for the review!

On Thu 28 Apr 2011 20:12, Neil Jerram <neil@ossau.uklinux.net> writes:

> +@example
> +(while #f (error "not reached")) @result{} #f
> +(while #t (break)) @result{} #t
> +(while #f (break 1 2 3)) @result{} 1 2 3
> +@end example
>
> I think the #f in the last while line should be #t.

Indeed, fixed.

>             (if (pair? do-script)
>                 (set-car! do-script arg))
>             (set! arg0 arg)
>             (set! interactive? #f)
>             (finish args
>                     (cons `(load ,arg) out)))
>
> Does this code mean that we load the script twice, in the -ds case?

I think so, yes; unfortunately.  Fixed.  Would this merit a quick 2.0.2,
you think?

>
> If that's right, I believe the -s block has the same issue.
>
>            ((string=? arg "-x")         ; add to %load-extensions
>             (if (null? args)
>                 (error "missing argument to `-L' switch"))
>             (set! user-extensions (cons (car args) user-extensions))
>             (parse (cdr args)
>                    out))
>
> In the error message here, -L should be -x.

Fixed also.

> Do we go interactive after seeing a -e option?  I don't see a setting of
> the interactive? variable that would prevent this?

This appears to be the old behavior.  Am I mistaken?

Thanks,

Andy
-- 
http://wingolog.org/



  reply	other threads:[~2011-04-28 19:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 18:12 Queries about while doc and (ice-9 command-line) Neil Jerram
2011-04-28 19:47 ` Andy Wingo [this message]
2011-05-02 17:21   ` Neil Jerram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m339l217kz.fsf@unquote.localdomain \
    --to=wingo@pobox.com \
    --cc=guile-devel@gnu.org \
    --cc=neil@ossau.uklinux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).