From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] First batch of numerics changes Date: Sun, 30 Jan 2011 13:12:06 +0100 Message-ID: References: <87lj2762xc.fsf@yeeloong.netris.org> <87tygv4726.fsf@yeeloong.netris.org> <87wrlo2k9z.fsf@yeeloong.netris.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1296391065 7295 80.91.229.12 (30 Jan 2011 12:37:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 30 Jan 2011 12:37:45 +0000 (UTC) Cc: guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Jan 30 13:37:41 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PjWXE-0008WF-Pt for guile-devel@m.gmane.org; Sun, 30 Jan 2011 13:37:41 +0100 Original-Received: from localhost ([127.0.0.1]:60745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjWXE-0002xK-3g for guile-devel@m.gmane.org; Sun, 30 Jan 2011 07:37:40 -0500 Original-Received: from [140.186.70.92] (port=50116 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjWWf-0002j0-Qd for guile-devel@gnu.org; Sun, 30 Jan 2011 07:37:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PjWWe-0002Z9-8D for guile-devel@gnu.org; Sun, 30 Jan 2011 07:37:05 -0500 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:56762 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PjWWe-0002Z3-6K for guile-devel@gnu.org; Sun, 30 Jan 2011 07:37:04 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 9C8FE32C9; Sun, 30 Jan 2011 07:37:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=bQBNRQlpCh/Z7tPsyXFsJ1HbAgs=; b=SH2F3u ADvyolNfUSJZSnFMyeARw4Pu0TSVy/Kxn5DsXfw3MIVTl4mOIrCsvbGqT2XBSfhx wHjHg1aViOrnpWd6Y94KPKyJafZjB8Xmk+ihcUfJ8t2QAjImA/BJ9TYmPFfYxl/z NVysenVKqTbBfp8SHRRhdQl4W/EeTziQGOX88= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=Cf4EpMSaACSBrReYU85yGrTw08PdtSU6 pNoL6Nj4o6m7QPlfXfLL5rkACU082hKzmlqBfRu428SLyBHHf2PTUYqhOp2i+uys WOCy8ldnBpoHvs9d3PHF1hYkFWI42if5ZWbF8pthDYYbcj+RWep7SRxV8AAYExE4 ndzRCHB0Pvo= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 680E932C8; Sun, 30 Jan 2011 07:37:54 -0500 (EST) Original-Received: from unquote.localdomain (unknown [90.164.198.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id C2B0B32C2; Sun, 30 Jan 2011 07:37:52 -0500 (EST) In-Reply-To: <87wrlo2k9z.fsf@yeeloong.netris.org> (Mark H. Weaver's message of "Sat, 29 Jan 2011 03:20:40 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: C24AC1EC-2C6D-11E0-83DB-BC4EF3E828EC-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 64.74.157.62 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11424 Archived-At: On Sat 29 Jan 2011 09:20, Mark H Weaver writes: > @@ -728,7 +728,7 @@ SCM_PRIMITIVE_GENERIC (scm_abs, "abs", 1, 0, 0, > "Return the absolute value of @var{x}.") > #define FUNC_NAME > { > - if (SCM_I_INUMP (x)) > + if (SCM_LIKELY (SCM_I_INUMP (x))) > { > scm_t_inum xx = SCM_I_INUM (x); > if (xx >= 0) Is this really likely the case? Probably not. I'm going to hold off on this patch, unless you really want it in. I applied the other four in your series, though not including the div0 one. Thanks for the patches! Andy -- http://wingolog.org/