From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Marius Vollmer Newsgroups: gmane.lisp.guile.devel Subject: Re: Copy-on-write strings and mutation-sharing strings Date: Fri, 20 Aug 2004 12:49:04 +0200 Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: References: <87ekm2a90n.fsf@zip.com.au> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1092998991 31966 80.91.224.253 (20 Aug 2004 10:49:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 20 Aug 2004 10:49:51 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Aug 20 12:49:41 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1By6xp-0004yS-00 for ; Fri, 20 Aug 2004 12:49:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1By728-0008NG-0A for guile-devel@m.gmane.org; Fri, 20 Aug 2004 06:54:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1By71t-0008Kn-S1 for guile-devel@gnu.org; Fri, 20 Aug 2004 06:53:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1By71s-0008K4-59 for guile-devel@gnu.org; Fri, 20 Aug 2004 06:53:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1By71s-0008Ju-3G for guile-devel@gnu.org; Fri, 20 Aug 2004 06:53:52 -0400 Original-Received: from [129.217.163.1] (helo=mail.dt.e-technik.uni-dortmund.de) by monty-python.gnu.org with esmtp (Exim 4.34) id 1By6xH-00024t-96 for guile-devel@gnu.org; Fri, 20 Aug 2004 06:49:07 -0400 Original-Received: from troy.dt.e-technik.uni-dortmund.de (troy.dt.e-technik.uni-dortmund.de [129.217.163.17]) by mail.dt.e-technik.uni-dortmund.de (Postfix) with ESMTP id 796B72BE13 for ; Fri, 20 Aug 2004 12:49:05 +0200 (CEST) Original-Received: by troy.dt.e-technik.uni-dortmund.de (Postfix, from userid 520) id 0D854B99A; Fri, 20 Aug 2004 12:49:04 +0200 (CEST) Original-To: guile-devel@gnu.org In-Reply-To: <87ekm2a90n.fsf@zip.com.au> (Kevin Ryde's message of "Fri, 20 Aug 2004 11:33:12 +1000") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:3994 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:3994 Kevin Ryde writes: > I applied a fix to mkstemp! since it needs to modify it's input > string. Right, thanks! > This crept in with the locale_string business. You can check if > it's right. New test case in posix.test too. The fix is not entirely correct, since mkstemp expects a null-terminated string but scm_i_strings_writable_chars isn't guaranteed to give you one. [ Also, mkstemp should get a string in the current locale encoding, but the internal encoding of Guile might differ from that in the future. Much work needs to be done anyway when that happens, but when can get mkstemp! right now, we should. ] I fixed this by copying the modified template back into the SCM string. Please check. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel