From: Marius Vollmer <marius.vollmer@uni-dortmund.de>
Subject: Re: Copy-on-write strings and mutation-sharing strings
Date: Fri, 20 Aug 2004 12:49:04 +0200 [thread overview]
Message-ID: <ljekm2t78f.fsf@troy.dt.e-technik.uni-dortmund.de> (raw)
In-Reply-To: <87ekm2a90n.fsf@zip.com.au> (Kevin Ryde's message of "Fri, 20 Aug 2004 11:33:12 +1000")
Kevin Ryde <user42@zip.com.au> writes:
> I applied a fix to mkstemp! since it needs to modify it's input
> string.
Right, thanks!
> This crept in with the locale_string business. You can check if
> it's right. New test case in posix.test too.
The fix is not entirely correct, since mkstemp expects a
null-terminated string but scm_i_strings_writable_chars isn't
guaranteed to give you one.
[ Also, mkstemp should get a string in the current locale encoding,
but the internal encoding of Guile might differ from that in the
future. Much work needs to be done anyway when that happens, but
when can get mkstemp! right now, we should.
]
I fixed this by copying the modified template back into the SCM
string. Please check.
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2004-08-20 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-19 19:05 Copy-on-write strings and mutation-sharing strings Marius Vollmer
2004-08-20 1:33 ` Kevin Ryde
2004-08-20 10:49 ` Marius Vollmer [this message]
2004-08-22 1:52 ` Kevin Ryde
2004-08-22 1:33 ` Kevin Ryde
2004-08-22 7:44 ` Marius Vollmer
2004-08-22 1:34 ` Kevin Ryde
2004-08-24 17:21 ` Marius Vollmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ljekm2t78f.fsf@troy.dt.e-technik.uni-dortmund.de \
--to=marius.vollmer@uni-dortmund.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).