From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Han-Wen Nienhuys Newsgroups: gmane.lisp.guile.devel Subject: Re: Cleanup mark-during-GC debug checks. Date: Tue, 09 Sep 2008 22:13:02 -0300 Message-ID: References: <00163630f0ef5b47e60456777f02@google.com> <87sks9i5ow.fsf@gnu.org> Reply-To: hanwen@xs4all.nl NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1221009295 6872 80.91.229.12 (10 Sep 2008 01:14:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Sep 2008 01:14:55 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 10 03:15:51 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KdEJC-0001mU-03 for guile-devel@m.gmane.org; Wed, 10 Sep 2008 03:15:50 +0200 Original-Received: from localhost ([127.0.0.1]:57487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KdEIB-0007kJ-Ms for guile-devel@m.gmane.org; Tue, 09 Sep 2008 21:14:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KdEI5-0007hN-5Y for guile-devel@gnu.org; Tue, 09 Sep 2008 21:14:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KdEI3-0007gj-5G for guile-devel@gnu.org; Tue, 09 Sep 2008 21:14:40 -0400 Original-Received: from [199.232.76.173] (port=47820 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KdEI2-0007gg-So for guile-devel@gnu.org; Tue, 09 Sep 2008 21:14:38 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:43930 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KdEI2-00024n-Gz for guile-devel@gnu.org; Tue, 09 Sep 2008 21:14:38 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KdEI0-0000e7-5F for guile-devel@gnu.org; Wed, 10 Sep 2008 01:14:36 +0000 Original-Received: from 201.80.3.52 ([201.80.3.52]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 10 Sep 2008 01:14:36 +0000 Original-Received: from hanwen by 201.80.3.52 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 10 Sep 2008 01:14:36 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 50 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 201.80.3.52 User-Agent: Thunderbird 2.0.0.16 (X11/20080723) In-Reply-To: <87sks9i5ow.fsf@gnu.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7652 Archived-At: Ludovic Courtès escreveu: > Hello! > > hanwenn@gmail.com writes: > >> Reviewers: hanwenn, >> >> Message: >> Hello guile devel, >> >> please go to >> >> http://codereview.appspot.com/4847 >> >> to review this patch. >> >> >> I hope you like it; thanks! > > A couple of notes: > > 1. I don't want to use a web interface to review code. Most free > software projects use email in one form or another, which I find > convenient. Having patches in-lined is optimal IMO. My experience is that a web interface (which tracks different versions of the same patch) is a lot easier when it is a major change with lots of revisions. In general, I find cutting & pasting patches into emails clumsy and error prone. In general, git is much better suited for sending patches around. > 2. I don't want to have a Google account. > > Thus, I'll comment on the patch here. > > * I'd name the macro `SCM_DEBUG_MARK_PHASE' rather, as it sounds mot > idiomatic (but I'm not a native speaker). It's rather the reverse: ensuring that the non-mark phase is correct (in not having mark calls), but I couldn't think of a good name. > * Use "static const char msg[] = ...". done. -- Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen