From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Han-Wen Nienhuys Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Avoid `SCM_VALIDATE_LIST ()' Date: Sun, 07 Sep 2008 16:25:43 -0300 Message-ID: References: <87hc90u9lb.fsf@gnu.org> <49dd78620809061545h1a1aa8e4t8e4c10772ab5b137@mail.gmail.com> <49dd78620809070638p1498c537u8488ddb87109b6f4@mail.gmail.com> <49dd78620809070919t2f8c903cx17a1b7b075a0f506@mail.gmail.com> Reply-To: hanwen@xs4all.nl NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1220815656 14380 80.91.229.12 (7 Sep 2008 19:27:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Sep 2008 19:27:36 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Sep 07 21:28:32 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KcPvz-0008P8-DK for guile-devel@m.gmane.org; Sun, 07 Sep 2008 21:28:31 +0200 Original-Received: from localhost ([127.0.0.1]:47405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcPuz-0006Hk-5X for guile-devel@m.gmane.org; Sun, 07 Sep 2008 15:27:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KcPuq-0006DM-L1 for guile-devel@gnu.org; Sun, 07 Sep 2008 15:27:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KcPuo-00069t-Jl for guile-devel@gnu.org; Sun, 07 Sep 2008 15:27:19 -0400 Original-Received: from [199.232.76.173] (port=42111 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcPuo-00069c-Aj for guile-devel@gnu.org; Sun, 07 Sep 2008 15:27:18 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:38437 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KcPuo-0003Mt-5O for guile-devel@gnu.org; Sun, 07 Sep 2008 15:27:18 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KcPuk-0000Gw-R6 for guile-devel@gnu.org; Sun, 07 Sep 2008 19:27:14 +0000 Original-Received: from 201.80.3.52 ([201.80.3.52]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 07 Sep 2008 19:27:14 +0000 Original-Received: from hanwen by 201.80.3.52 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 07 Sep 2008 19:27:14 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 201.80.3.52 User-Agent: Thunderbird 2.0.0.16 (X11/20080723) In-Reply-To: <49dd78620809070919t2f8c903cx17a1b7b075a0f506@mail.gmail.com> X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7615 Archived-At: Neil Jerram escreveu: > Since you mention 'cleanups', I must say that I agree with Ludovic, > that it would have been preferable to post the patch for > review/discussion before committing it, since that is our (majority) > current practice. Sure there may have been a few exceptions, but only > for trivial changes, I believe, and I don't believe that this was - > overall - a trivial change. (I'm aware that it has lots of trivial > bits in it, but I don't think it's all trivial.) > > (I also think it's arguable that actually committing to a branch is > more convenient, for author and reviewers, than juggling emails - but > that then leads on to other questions, like what expectations people > can have of the "master" branch, and why we are using Git like CVS...) If we want to code review as a policy, I'm fine with that, but let's do it in a structured way then. Guido van Rossum wrote a webtool for code review, which should be fairly easy to use and setup http://code.google.com/appengine/articles/rietveld.html and I heard people have recently added Git support to it. How about using this for Guile? (We need to figure out how to set it up, and contributors need to have gmail addresses, but that should not be a problem, is it?) -- Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen