From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Han-Wen Nienhuys Newsgroups: gmane.lisp.guile.devel Subject: Re: GUILE_MAX_HEAP_SIZE Date: Fri, 22 Aug 2008 00:36:29 -0300 Message-ID: References: <87ej4tmf4m.fsf@gnu.org> <87d4k7e0s8.fsf@gnu.org> <87hc9iwyxi.fsf@gnu.org> <878wuus5fc.fsf@gnu.org> <87abf9qffj.fsf@gnu.org> <87od3musff.fsf@gnu.org> Reply-To: hanwen@xs4all.nl NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1219376299 28135 80.91.229.12 (22 Aug 2008 03:38:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Aug 2008 03:38:19 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Aug 22 05:39:12 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KWNUV-0002Bj-C9 for guile-devel@m.gmane.org; Fri, 22 Aug 2008 05:39:11 +0200 Original-Received: from localhost ([127.0.0.1]:46091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWNTX-0002rj-Mc for guile-devel@m.gmane.org; Thu, 21 Aug 2008 23:38:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWNTS-0002re-9L for guile-devel@gnu.org; Thu, 21 Aug 2008 23:38:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWNTP-0002rR-Sg for guile-devel@gnu.org; Thu, 21 Aug 2008 23:38:06 -0400 Original-Received: from [199.232.76.173] (port=37789 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWNTP-0002rO-KZ for guile-devel@gnu.org; Thu, 21 Aug 2008 23:38:03 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:49560 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KWNTP-0002R4-Ed for guile-devel@gnu.org; Thu, 21 Aug 2008 23:38:03 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KWNTG-0005og-PD for guile-devel@gnu.org; Fri, 22 Aug 2008 03:37:54 +0000 Original-Received: from 201.80.3.52 ([201.80.3.52]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 22 Aug 2008 03:37:54 +0000 Original-Received: from hanwen by 201.80.3.52 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 22 Aug 2008 03:37:54 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 201.80.3.52 User-Agent: Thunderbird 2.0.0.16 (X11/20080723) In-Reply-To: X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7485 Archived-At: Han-Wen Nienhuys escreveu: > Ludovic Courtès escreveu: >> Hello, >> >> Han-Wen Nienhuys writes: >> >>> Ludovic Courtès escreveu: >>>> Off the top of my head: incorrect indentation, missing spaces around >>>> brackets, and more importantly comments (see (standards.info)Comments). >>> The code I went through should not have that; please point me to locations >>> where things are broken so I can fix them. >> E.g., from commit: >> >> +/* >> + Classic MIT Hack, see e.g. http://www.tekpool.com/?cat=9 >> + */ >> +int scm_i_uint_bit_count(unsigned int u) >> >> (BTW, it'd make sense to use Gnulib's `count-one-bits' module, which is >> able to use GCC's `__builtin_popcount ()'.) Could you add the gnulib module? I'll do the rest. -- Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen