From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Paul Adrian Glaubitz Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH, v2] Fix build on platforms where the stack grows upwards Date: Wed, 22 Jul 2020 23:54:54 +0200 Message-ID: References: <20200204121152.3335558-1-glaubitz@physik.fu-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18706"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: wingo@igalia.com, deller@gmx.de, dave.anglin@bell.net To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Jul 22 23:55:19 2020 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyMhp-0004gp-V6 for guile-devel@m.gmane-mx.org; Wed, 22 Jul 2020 23:55:18 +0200 Original-Received: from localhost ([::1]:51376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyMho-0003L0-Pv for guile-devel@m.gmane-mx.org; Wed, 22 Jul 2020 17:55:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyMhc-0003Ka-OK for guile-devel@gnu.org; Wed, 22 Jul 2020 17:55:04 -0400 Original-Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]:39655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyMha-0000Pc-CQ for guile-devel@gnu.org; Wed, 22 Jul 2020 17:55:04 -0400 Original-Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.93) with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (envelope-from ) id 1jyMhT-000JES-FG; Wed, 22 Jul 2020 23:54:55 +0200 Original-Received: from p57bd9e19.dip0.t-ipconnect.de ([87.189.158.25] helo=[192.168.178.139]) by inpost2.zedat.fu-berlin.de (Exim 4.93) with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (envelope-from ) id 1jyMhT-002Klk-8T; Wed, 22 Jul 2020 23:54:55 +0200 Autocrypt: addr=glaubitz@physik.fu-berlin.de; keydata= mQINBE3JE9wBEADMrYGNfz3oz6XLw9XcWvuIxIlPWoTyw9BxTicfGAv0d87wngs9U+d52t/R EggPePf34gb7/k8FBY1IgyxnZEB5NxUb1WtW0M3GUxpPx6gBZqOm7SK1ZW3oSORw+T7Aezl3 Zq4Nr4Nptqx7fnLpXfRDs5iYO/GX8WuL8fkGS/gIXtxKewd0LkTlb6jq9KKq8qn8/BN5YEKq JlM7jsENyA5PIe2npN3MjEg6p+qFrmrzJRuFjjdf5vvGfzskrXCAKGlNjMMA4TgZvugOFmBI /iSyV0IOaj0uKhes0ZNX+lQFrOB4j6I5fTBy7L/T3W/pCWo3wVkknNYa8TDYT73oIZ7Aimv+ k7OzRfnxsSOAZT8Re1Yt8mvzr6FHVFjr/VdyTtO5JgQZ6LEmvo4Ro+2ByBmCHORCQ0NJhD1U 3avjGfvfslG999W0WEZLTeaGkBAN1yG/1bgGAytQQkD9NsVXqBy7S3LVv9bB844ysW5Aj1nv tgIz14E2WL8rbpfjJMXi7B5ha6Lxf3rFOgxpr6ZoEn+bGG4hmrO+/ReA4SerfMqwSTnjZsZv xMJsx2B9c8DaZE8GsA4I6lsihbJmXhw8i7Cta8Dx418wtEbXhL6m/UEk60O7QD1VBgGqDMnJ DFSlvKa9D+tZde/kHSNmQmLLzxtDbNgBgmR0jUlmxirijnm8bwARAQABtFRKb2huIFBhdWwg QWRyaWFuIEdsYXViaXR6IChGcmVpZSBVbml2ZXJzaXRhZXQgQmVybGluKSA8Z2xhdWJpdHpA cGh5c2lrLmZ1LWJlcmxpbi5kZT6JAl In-Reply-To: <20200204121152.3335558-1-glaubitz@physik.fu-berlin.de> Content-Language: en-US X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.158.25 Received-SPF: pass client-ip=130.133.4.66; envelope-from=glaubitz@zedat.fu-berlin.de; helo=outpost1.zedat.fu-berlin.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 17:54:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20556 Archived-At: Hello! On 2/4/20 1:11 PM, John Paul Adrian Glaubitz wrote: > diff --git a/libguile/continuations.c b/libguile/continuations.c > index 3f86c6bd4..67a47d38c 100644 > --- a/libguile/continuations.c > +++ b/libguile/continuations.c > @@ -323,7 +323,7 @@ scm_dynthrow (SCM cont, uint8_t *mra) > > #if SCM_STACK_GROWS_UP > if (dst + continuation->num_stack_items >= &stack_top_element) > - grow_stack (cont); > + grow_stack (cont, mra); > #else > dst -= continuation->num_stack_items; > if (dst <= &stack_top_element) Looks like this was just broken again in 2.2.7 on hppa [1]: continuations.c: In function 'scm_dynthrow': continuations.c:305:23: error: 'mra' undeclared (first use in this function) 305 | grow_stack (cont, mra); | ^~~ continuations.c:305:23: note: each undeclared identifier is reported only once for each function it appears in continuations.c:305:5: error: too many arguments to function 'grow_stack' 305 | grow_stack (cont, mra); | ^~~~~~~~~~ continuations.c:237:1: note: declared here 237 | grow_stack (SCM cont) | ^~~~~~~~~~ make[4]: *** [Makefile:2844: libguile_2.2_la-continuations.lo] Error 1 make[4]: *** Waiting for unfinished jobs.... I just saw it was already fixed for 2.2.8 but that hasn't been released yet [2] :(. Adrian > [1] https://buildd.debian.org/status/fetch.php?pkg=guile-2.2&arch=hppa&ver=2.2.7%2B1-1&stamp=1584637426&raw=0 > [2] http://git.savannah.gnu.org/cgit/guile.git/commit/?h=stable-2.2&id=7839dc444b94568579c510737bc358fa6f4470ee -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913