Re: [PATCH, v2] Fix build on platforms where the stack grows upwards

[John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>]

Hello!

On 2/4/20 1:11 PM, John Paul Adrian Glaubitz wrote:
> diff --git a/libguile/continuations.c b/libguile/continuations.c
> index 3f86c6bd4..67a47d38c 100644
> --- a/libguile/continuations.c
> +++ b/libguile/continuations.c
> @@ -323,7 +323,7 @@ scm_dynthrow (SCM cont, uint8_t *mra)
>  
>  #if SCM_STACK_GROWS_UP
>    if (dst + continuation->num_stack_items >= &stack_top_element)
> -    grow_stack (cont);
> +    grow_stack (cont, mra);
>  #else
>    dst -= continuation->num_stack_items;
>    if (dst <= &stack_top_element)

Looks like this was just broken again in 2.2.7 on hppa [1]:

continuations.c: In function 'scm_dynthrow':
continuations.c:305:23: error: 'mra' undeclared (first use in this function)
  305 |     grow_stack (cont, mra);
      |                       ^~~
continuations.c:305:23: note: each undeclared identifier is reported only once for each function it appears in
continuations.c:305:5: error: too many arguments to function 'grow_stack'
  305 |     grow_stack (cont, mra);
      |     ^~~~~~~~~~
continuations.c:237:1: note: declared here
  237 | grow_stack (SCM cont)
      | ^~~~~~~~~~
make[4]: *** [Makefile:2844: libguile_2.2_la-continuations.lo] Error 1
make[4]: *** Waiting for unfinished jobs....

I just saw it was already fixed for 2.2.8 but that hasn't been released yet [2] :(.

Adrian

> [1] https://buildd.debian.org/status/fetch.php?pkg=guile-2.2&arch=hppa&ver=2.2.7%2B1-1&stamp=1584637426&raw=0
> [2] http://git.savannah.gnu.org/cgit/guile.git/commit/?h=stable-2.2&id=7839dc444b94568579c510737bc358fa6f4470ee

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913