unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: "H. Müller" <h.c.f.mueller@gmail.com>
To: maximedevos@telenet.be, guile-devel@gnu.org
Subject: [PATCH v2] Fix make-custom-port in case encoding is #f
Date: Sun, 02 Feb 2025 22:01:56 +0100	[thread overview]
Message-ID: <f9e083d9b674795cfd5a855eb978c36710070d91.camel@gmail.com> (raw)
In-Reply-To: 0b60f59f-fcb9-44ca-8459-2c41fad8a17d@telenet.be

Hi Maxime,
Thanks for hint with the explanation. I'm still learning. 
Below the second try.

Best Regards
Hannes


From 5eb06c5d22799170289ab55ab5a8eab45a98b390 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hannes=20M=C3=BCller?= <>
Date: Sun, 2 Feb 2025 21:32:18 +0100
Subject: [PATCH v2] Fix make-custom-port in case encoding is #f

* module/ice-9/custom-ports.scm (make-custom-port): Code fails if
(fluid-ref %default-port-encoding) returns #f. In fact this was the
case why readline support on MSYS2 failed for guile 3.0.10, ref.
https://github.com/msys2/MSYS2-packages/issues/5079
But later used canonicalize-encoding is prepared to handle #f for
encoding. So allow encoding to also handle this case.
---
 module/ice-9/custom-ports.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/module/ice-9/custom-ports.scm b/module/ice-9/custom-ports.scm
index 6010fd94f..c4376db7b 100644
--- a/module/ice-9/custom-ports.scm
+++ b/module/ice-9/custom-ports.scm
@@ -127,7 +127,7 @@
           (id "custom-port")
           (print (make-default-print #:id id))
           (truncate default-truncate)
-          (encoding (string->symbol (fluid-ref %default-port-encoding)))
+          (encoding (and=> (fluid-ref %default-port-encoding) string->symbol))
           (conversion-strategy (fluid-ref %default-port-conversion-strategy))
           (close-on-gc? #f))
   "Create a custom port whose behavior is determined by the methods passed
-- 
2.39.5




             reply	other threads:[~2025-02-02 21:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-02 21:01 H. Müller [this message]
2025-02-02 21:07 ` [PATCH v2] Fix make-custom-port in case encoding is #f Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9e083d9b674795cfd5a855eb978c36710070d91.camel@gmail.com \
    --to=h.c.f.mueller@gmail.com \
    --cc=guile-devel@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).