From: Maxime Devos <maximedevos@telenet.be>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>, guile-devel@gnu.org
Subject: Re: GC + Java finalization
Date: Fri, 19 Nov 2021 14:01:58 +0000 [thread overview]
Message-ID: <f6414722369feb017713efc801dd69f6f23f6fd6.camel@telenet.be> (raw)
In-Reply-To: <d60bf5ff68e769c07f15bdc6acdacb5e5c1b09a3.camel@hahnjo.de>
Jonas Hahnfeld schreef op vr 19-11-2021 om 14:53 [+0100]:
> [...]
> The straight-forward solution is to statically tie the lifetime of
> regex_t to that of the smob. Which we cannot do with GC, but simply
> with malloc+free - as implemented in the patch.
OK, but for clarity I recommend adding a comment like
/* When not using Java-style finalisation, we must make sure
the memory for the regex_t is only freed after regfree.
To do so, use scm_malloc+free instead of scm_gc_free such
that boehmgc will only free the regex_t when we ask it to
in regex_free, and it won't automatically free the regex_t
too early. */
Otherwise, it would be easy to think ‘Hmm, this code would be
simpler if we just use scm_gc_malloc and remove the unnecessary
free’ and accidentally introduce a bug ...
Greetings,
Maxime
next prev parent reply other threads:[~2021-11-19 14:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 12:05 GC + Java finalization Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-07-03 17:14 ` Maxime Devos
2021-07-03 17:26 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-07-03 18:49 ` Maxime Devos
2021-07-03 18:54 ` Maxime Devos
2021-07-15 18:44 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-10-10 16:22 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 12:18 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2022-02-22 10:14 ` Dr. Arne Babenhauserheide
2022-02-22 15:12 ` Mike Gran
2021-11-19 13:13 ` Maxime Devos
2021-11-19 13:32 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:35 ` Maxime Devos
2021-11-19 13:40 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:44 ` Maxime Devos
2021-11-19 13:53 ` Maxime Devos
2021-11-19 13:53 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:01 ` Maxime Devos [this message]
2021-11-19 13:48 ` Maxime Devos
2021-11-19 13:55 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:14 ` Maxime Devos
2021-11-19 14:52 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 18:48 ` Maxime Devos
2021-11-19 19:01 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:15 ` Maxime Devos
2021-11-19 13:35 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:21 ` Maxime Devos
2021-11-19 15:32 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:17 ` Maxime Devos
2021-11-19 13:38 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-20 9:19 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6414722369feb017713efc801dd69f6f23f6fd6.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=guile-devel@gnu.org \
--cc=hahnjo@hahnjo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).