[patch] Add instructions for sending patches

[patch] Add instructions for sending patches

[Dr. Arne Babenhauserheide]

[-- Attachment #1.1: Type: text/plain, Size: 223 bytes --]

Hi,

the attached patch adds a small section to the website that I’ve been
missing a few times already, so I thought I’ll just add it :-)

The patch is for https://git.savannah.gnu.org/cgit/guile/guile-web.git/


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Add-instructions-for-sending-patches.patch --]
[-- Type: text/x-patch, Size: 1705 bytes --]

From 11da5a6eacb0052e66065bf39a34c55bd496b431 Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide <arne_bab@web.de>
Date: Sat, 11 Dec 2021 16:12:17 +0100
Subject: [PATCH] Add instructions for sending patches

---
 website/apps/base/contribute-page.scm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/website/apps/base/contribute-page.scm b/website/apps/base/contribute-page.scm
index 630f05c..78441bf 100644
--- a/website/apps/base/contribute-page.scm
+++ b/website/apps/base/contribute-page.scm
@@ -60,6 +60,22 @@
 	   "are available in "
 	   (a (@ (href "https://savannah.gnu.org/git/?group=guile"))
 	      "Git repositories") " at Savannah.")
+	(h2 (@ (id "patches")) "Sending patches")
+	(p "To contribute small improvements, please send patches to "
+	   (a (@ (href "mailto:guile-devel@gnu.org")) "guile-devel@gnu.org")
+       ".")
+	(ul
+	 (li "Please send a patch and commit log as produced by "
+	     (code "git format-patch") ".")
+	 (li "Please include a "
+	     (a (@ (href "http://www.gnu.org/prep/standards/standards.html#Change-Logs")) "ChangeLog-style commit log")
+	     " with your patch.")
+	 (li "If the patch changes more than about ten lines of code, we "
+	     "may ask you to assign your copyright to the FSF before it can "
+	     "be applied."))
+	(p "For larger changes, please discuss them first in the "
+	   (a (@ (href "https://mail.gnu.org/mailman/listinfo/guile-devel/")) "development mailing list")
+       ".")
 	(h2 (@ (id "bugs")) "Reporting bugs")
 	(p "You do us a much-appreciated service when you report the bugs "
 	   "you find in Guile. Please don't assume we already know about "
-- 
2.34.0


[-- Attachment #1.3: Type: text/plain, Size: 101 bytes --]


Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1125 bytes --]

Re: [patch] Add instructions for sending patches

[Maxime Devos]

Hi,

Dr. Arne Babenhauserheide schreef op za 11-12-2021 om 16:12 [+0100]:
> +	(p "To contribute small improvements, please send patches to
> "
> +	   (a (@ (href "mailto:guile-devel@gnu.org"))
> "guile-devel@gnu.org")
> +       ".")

What about contributing _large_ improvements?
Where should patches for large improvements go?

> +	(p "For larger changes, please discuss them first in the "
> +	   (a (@ (href "https://mail.gnu.org/mailman/listinfo/guile->
devel/")) "development mailing list")

What if I tried to discuss them, but nobody answered?
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46258)
(Not 100% accurate though, because I discussed the interface on IRC a
bit IIRC? I can't find it in the logs anymore though.)

What if, I then proceed with writing the patches, and nobody responds
with some points to work on or applies it?
(https://lists.gnu.org/archive/html/guile-devel/2021-03/msg00026.html)
(The only response is a +1-style response.)

What if, eight months later, I send a simplified patch series, with
things made more consistent, and with much more tests, and this time,
there is exactly one response, with a minor point that is quickly
addressed
(https://lists.gnu.org/archive/html/guile-devel/2021-11/msg00019.html),
but the patches aren't applied?

There have been many commits and two releases since the first patch
series
(https://git.savannah.gnu.org/cgit/guile.git/log/?id=653cc0bf953a11432f77ade9c007848e947cc430&qt=range&q=653cc0bf953a11432f77ade9c007848e947cc430..HEAD&ofs=100)
, without any signs that it will actually ever be applied.

So I guess what I'm trying to say, is that while your patch documenting
how to contribute seems reasonable to me, it has been very inaccurate
for me in practice (not your fault!).

Greetings,
Maxime