unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: "Dr. Arne Babenhauserheide" <arne_bab@web.de>, guile-devel@gnu.org
Subject: Re: [patch] Add instructions for sending patches
Date: Sat, 11 Dec 2021 19:33:02 +0000	[thread overview]
Message-ID: <e03eaa27d571a20caf87e8f58fdda2388ef850f9.camel@telenet.be> (raw)
In-Reply-To: <87czm3rx12.fsf@web.de>

Hi,

Dr. Arne Babenhauserheide schreef op za 11-12-2021 om 16:12 [+0100]:
> +	(p "To contribute small improvements, please send patches to
> "
> +	   (a (@ (href "mailto:guile-devel@gnu.org"))
> "guile-devel@gnu.org")
> +       ".")

What about contributing _large_ improvements?
Where should patches for large improvements go?

> +	(p "For larger changes, please discuss them first in the "
> +	   (a (@ (href "https://mail.gnu.org/mailman/listinfo/guile->
devel/")) "development mailing list")

What if I tried to discuss them, but nobody answered?
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46258)
(Not 100% accurate though, because I discussed the interface on IRC a
bit IIRC? I can't find it in the logs anymore though.)

What if, I then proceed with writing the patches, and nobody responds
with some points to work on or applies it?
(https://lists.gnu.org/archive/html/guile-devel/2021-03/msg00026.html)
(The only response is a +1-style response.)

What if, eight months later, I send a simplified patch series, with
things made more consistent, and with much more tests, and this time,
there is exactly one response, with a minor point that is quickly
addressed
(https://lists.gnu.org/archive/html/guile-devel/2021-11/msg00019.html),
but the patches aren't applied?

There have been many commits and two releases since the first patch
series
(https://git.savannah.gnu.org/cgit/guile.git/log/?id=653cc0bf953a11432f77ade9c007848e947cc430&qt=range&q=653cc0bf953a11432f77ade9c007848e947cc430..HEAD&ofs=100)
, without any signs that it will actually ever be applied.

So I guess what I'm trying to say, is that while your patch documenting
how to contribute seems reasonable to me, it has been very inaccurate
for me in practice (not your fault!).

Greetings,
Maxime




      reply	other threads:[~2021-12-11 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-11 15:12 [patch] Add instructions for sending patches Dr. Arne Babenhauserheide
2021-12-11 19:33 ` Maxime Devos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e03eaa27d571a20caf87e8f58fdda2388ef850f9.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=arne_bab@web.de \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).