From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: hanwen@byrd.xs4all.nl (Han-Wen Nienhuys) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] GC code cleanup Date: Fri, 23 Dec 2005 11:23:01 +0000 (UTC) Organization: LilyPond development Message-ID: References: <87vexjoibu.fsf@laas.fr> Reply-To: hanwen@xs4all.nl NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1135343731 2714 80.91.229.2 (23 Dec 2005 13:15:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Dec 2005 13:15:31 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Dec 23 14:15:30 2005 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EpmlZ-0001rD-V3 for guile-devel@m.gmane.org; Fri, 23 Dec 2005 14:15:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Epmmc-0002Ih-V9 for guile-devel@m.gmane.org; Fri, 23 Dec 2005 08:16:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Epli0-0005WR-NJ for guile-devel@gnu.org; Fri, 23 Dec 2005 07:07:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Eplbh-0004ZZ-UN for guile-devel@gnu.org; Fri, 23 Dec 2005 07:02:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Epl2A-0002GG-Fw for guile-devel@gnu.org; Fri, 23 Dec 2005 06:24:30 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1Epl1Q-0004x8-S9 for guile-devel@gnu.org; Fri, 23 Dec 2005 06:23:41 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Epl0t-0006Jk-CC for guile-devel@gnu.org; Fri, 23 Dec 2005 12:23:07 +0100 Original-Received: from muurbloem.xs4all.nl ([213.84.26.127]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Dec 2005 12:23:07 +0100 Original-Received: from hanwen by muurbloem.xs4all.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Dec 2005 12:23:07 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: guile-devel@gnu.org Original-Lines: 28 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: muurbloem.xs4all.nl X-Newsreader: trn 4.0-test76 (Apr 2, 2001) Originator: hanwen@byrd.xs4all.nl (Han-Wen Nienhuys) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:5551 Archived-At: In article <87vexjoibu.fsf@laas.fr>, Ludovic Courtès wrote: >Hi, > >The patch below is an attempt to clean up the GC by limiting the use of >global variables for statistics. IMO it makes it easier to read the >code. Furthermore, it's also easier to track the exact number of cells >swept/collected at each stage. > thanks for your patch! > void >-scm_i_adjust_min_yield (scm_t_cell_type_statistics *freelist) >+scm_i_adjust_min_yield (scm_t_cell_type_statistics *freelist, >+ unsigned cells_collected, >+ unsigned cells_swept) you're passing this as a combination everywhere. I think it would be cleaner to create a scm_t_sweep_statistics containing these numbers. Also, you're passing these vars along mostly with with a scm_t_sweep_statistics ptr. Isn't it better to add the collected/swept numbers to that structure? d _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel