From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Enable utf8->string to take a range Date: Fri, 21 Jan 2022 17:53:23 +0100 Message-ID: References: <87h79x6abc.fsf@vijaymarupudi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-kxXXjB+t7X7VNVz5sg4w" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18030"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.38.3-1 To: Vijay Marupudi , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Fri Jan 21 17:59:14 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAxFq-0004SZ-18 for guile-devel@m.gmane-mx.org; Fri, 21 Jan 2022 17:59:14 +0100 Original-Received: from localhost ([::1]:51372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAxFp-0003tr-31 for guile-devel@m.gmane-mx.org; Fri, 21 Jan 2022 11:59:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAxAQ-0006KT-Qb for guile-devel@gnu.org; Fri, 21 Jan 2022 11:53:38 -0500 Original-Received: from [2a02:1800:120:4::f00:15] (port=34672 helo=andre.telenet-ops.be) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAxAO-0003Cx-AA for guile-devel@gnu.org; Fri, 21 Jan 2022 11:53:38 -0500 Original-Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by andre.telenet-ops.be with bizsmtp id lUtT2600Q4UW6Th01UtTL0; Fri, 21 Jan 2022 17:53:27 +0100 In-Reply-To: <87h79x6abc.fsf@vijaymarupudi.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1642784007; bh=ugsIdFhmBtqJvSUG83M52Z8e/cwuagMDAMEA9eL8kh4=; h=Subject:From:To:Date:In-Reply-To:References; b=Z0VebX6uGx8xM+k31UGW3hiOYHcWZUg5iIzWGSKpbhKTDalujzr3XY5s8Jd26Dzds zF8cYBfSiy0fxjPoHgp6zv4l/SdRFZNY5jG3B4/yqxX6jKYG4RSCeZ84j0BK4P8kx9 NPHecRsjjkONgwIZCEp3AX8YkbVQ7cG9NXZYO8nQ6QWCdnd3tn6RiUM8M0NyHlDJ/z lIh+LuErxsIIaXQBVT9g36R32c8T8L1pqgaWi2Xw7jwMdTKedcbegwNFIlnkTAazre l9IwL3h+vlgcXVZoKH2BzwIhd+VVEJmKoXqvcAgNVEZpa8+/9Zb4X4h/mrWgCK2cw/ NJ95/tBNknZNg== X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:1800:120:4::f00:15 (failed) Received-SPF: pass client-ip=2a02:1800:120:4::f00:15; envelope-from=maximedevos@telenet.be; helo=andre.telenet-ops.be X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21054 Archived-At: --=-kxXXjB+t7X7VNVz5sg4w Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Vijay Marupudi schreef op do 20-01-2022 om 22:23 [-0500]: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 c_start =3D scm_to_size_t (start); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (SCM_UNLIKELY (c_start >=3D c_len)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 scm_out_of_range = (FUNC_NAME, start); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!scm_is_eq (end, SCM_UNDEFINED)) > + { > + =C2=A0 c_end =3D scm_to_size_t (end); > + =C2=A0 if (SCM_UNLIKELY (c_end > c_len)) > + =C2=A0=C2=A0=C2=A0 scm_out_of_range (FUNC_NAME, end); IIUC, this will cause an out-of-range error for the following: (utf8->string "" 0 0) However, the following works: (substring "" 0 0) ; -> empty string There seems to be an inconsistency here. Can (c_start >=3D c_len) be relaxed to c_start > c_len? Greetings, Maxime. --=-kxXXjB+t7X7VNVz5sg4w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYerlAxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hadAQDiBY2TpJNQNsvP0yOT8pX2NvJT kMIZYVzM6eTAmLechAEA0ORwwQ/7POesNcs1C0/HfOPuD+TNUQ8TzykbSp8fZQw= =eE6c -----END PGP SIGNATURE----- --=-kxXXjB+t7X7VNVz5sg4w--