From: Maxime Devos <maximedevos@telenet.be>
To: Andrew Whatson <whatson@gmail.com>, guile-devel@gnu.org
Subject: Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.
Date: Thu, 22 Sep 2022 17:10:06 +0200 [thread overview]
Message-ID: <cb4f7b1c-071d-c8dc-967c-70e2e8cc37bb@telenet.be> (raw)
In-Reply-To: <20220922135358.22139-1-whatson@gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 982 bytes --]
On 22-09-2022 15:53, Andrew Whatson wrote:
> - (let ((val (frame-local-ref frame (binding-slot binding)
> - (binding-representation binding))))
> + (let* ((slot (binding-slot binding))
> + ;; HACK: Avoid out-of-range from frame-local-ref.
> + ;; Some frames have bindings beyond nlocals. That
> + ;; is probably a bug somewhere else, but at least
> + ;; this workaround allows them to be printed.
> + ;; See<https://bugs.gnu.org/57948>.
> + (val (if (< slot nlocals)
> + (frame-local-ref frame slot
> + (binding-representation binding))
> +*unspecified*)))
Looks reasonable from here, FWIW (I'm not familiar with (system vm frame)).
(Please keep in mind I do not have commit access.)
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-22 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 7:23 [PATCH] Avoid 'frame-local-ref' errors when printing backtrace Andrew Whatson
2022-09-21 10:50 ` Maxime Devos
2022-09-22 13:53 ` Andrew Whatson
2022-09-22 15:10 ` Maxime Devos [this message]
2022-10-12 20:34 ` Ludovic Courtès
2022-10-13 3:36 ` Andrew Whatson
2022-10-13 13:09 ` Ludovic Courtès
2023-01-11 5:24 ` Andrew Whatson
2023-01-11 23:03 ` Ludovic Courtès
2023-01-12 2:09 ` Andrew Whatson
2022-11-29 18:06 ` lloda
2022-09-22 13:58 ` Andrew Whatson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb4f7b1c-071d-c8dc-967c-70e2e8cc37bb@telenet.be \
--to=maximedevos@telenet.be \
--cc=guile-devel@gnu.org \
--cc=whatson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).