From: Manolis Ragkousis <manolis837@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] On Hurd, don't use not implemented madvise()
Date: Thu, 1 Jun 2017 19:27:27 +0300 [thread overview]
Message-ID: <c2bf1340-beb7-f383-ea7e-09d91c800942@gmail.com> (raw)
In-Reply-To: <87bmqayvx7.fsf@netris.org>
Hello Mark :)
On 05/30/2017 10:41 PM, Mark H Weaver wrote:
> Is there a test we could perform at run-time to discover whether
> madvise() is implemented? If so, that would be greatly preferable.
>
Well madvise() on Hurd is a glibc no-op that fails with errno = ENOSYS.
Maybe I could allow madvise to run once and if it fails set a global
static variable called madvise_implemented to 0 (by default 1) and use
this to stop it from running again. WDYT?
Also from my understanding not using madvise() ends up in slower
performance but it doesn't create problems to the program, right?
Because in this case, it stills compiles guile, the problem is that it
continuously spams "madvise failed: Function not implemented". I could
make it not print it when errno = ENOSYS. WDYT?
Thank you,
Manolis
next prev parent reply other threads:[~2017-06-01 16:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 9:26 [PATCH] On Hurd, don't use not implemented madvise() manolis837
2017-05-30 19:41 ` Mark H Weaver
2017-06-01 16:27 ` Manolis Ragkousis [this message]
2017-06-01 23:29 ` Mark H Weaver
2017-06-02 8:39 ` tomas
2017-06-03 2:00 ` Mark H Weaver
2017-06-03 6:41 ` tomas
2017-06-08 17:27 ` Efficiency of `map` (was: [PATCH] On Hurd, don't use not implemented madvise()) Stefan Monnier
2017-06-10 4:28 ` Efficiency of `map` Mark H Weaver
2017-06-10 4:38 ` Nala Ginrut
2017-06-11 5:27 ` Mark H Weaver
2017-07-02 18:57 ` [PATCH] On Hurd, silently ignore ENOSYS for madvise() manolis837
2017-07-02 18:57 ` manolis837
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2bf1340-beb7-f383-ea7e-09d91c800942@gmail.com \
--to=manolis837@gmail.com \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).