From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Hahnfeld via "Developers list for Guile, the GNU extensibility library" Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fixes for custom-ports Date: Wed, 29 Nov 2023 07:47:26 +0100 Message-ID: References: <441968d3aa118c66ddc376f66cc73bfcbf9578c4.camel@hahnjo.de> Reply-To: Jonas Hahnfeld Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-LSaKReZC2aDlrDBRQflK" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21290"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.50.1 Cc: guile-devel@gnu.org To: Jean Abou Samra , Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Nov 29 07:48:03 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8EMc-0005Jq-HG for guile-devel@m.gmane-mx.org; Wed, 29 Nov 2023 07:48:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8EMH-00050H-Gr; Wed, 29 Nov 2023 01:47:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8EMF-000503-9S for guile-devel@gnu.org; Wed, 29 Nov 2023 01:47:39 -0500 Original-Received: from backus.hahnjo.de ([2a03:4000:2a:2c1::1] helo=mail.hahnjo.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8EMD-0001iP-5Q for guile-devel@gnu.org; Wed, 29 Nov 2023 01:47:38 -0500 Original-Received: from [IPv6:2001:16b8:0:7700:2c58:eebf:7fe4:2b4] (200116b8000077002c58eebf7fe402b4.dip.versatel-1u1.de [IPv6:2001:16b8:0:7700:2c58:eebf:7fe4:2b4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hahnjo.de (Postfix) with ESMTPSA id BA1C075CD263; Wed, 29 Nov 2023 07:47:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hahnjo.de; s=default; t=1701240452; bh=h0VnqkYYzDsT2eaA+DIGD5yUiXlnxXnW93VJvqqR3v4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=mW3ffLzJg41nVySNyf0V5P1nnA7H697rDM46EI+flEn3gqtPl4HNFJp1ZpOLNBjdr +YMRqqgsb9w++cp7ma1MlYhMoAqhsbgZ+44NcmJ6v8TmRdL5hZsI+hdQSMKv9J0E6D Eax7BXXIFMh42Nl3KMIgP18ryjwDfY4xBd5LZnTNw/QtluFI0vTAgZP7jngPY0exNZ 9pSdIWKXUwdoZqn7P6g59I2gLWWiM//M5UIkybnVfaITv6gwZkreOlrP7pQbbnMDqX X/YgPZ6rwEPwrixlMpbEdCxD9zw3JZtrupcuz9sLq48Xc4iWdymdyJ4DBzn50OHKgq fwsn3+uWlVXxQ== In-Reply-To: Autocrypt: addr=hahnjo@hahnjo.de; prefer-encrypt=mutual; keydata=mQENBFIIleUBCAC94iH8XbAOTIPKPTRiMFcYyWaERWsRS1u3Cu6h3tlvTgLj02j9byL4uChGHhb0p6kuIqP89OlS/PGONDyMaMDvV4DL0woqbw87Y0qNLGHYiFtIXLqyhutHsNgsKObWKb2U7rhfmRbr5JUXFB3D5AWjKL1EBaYWlzH+wjJM3l3gqO9zmt5Q+4IhZkZHkb22SYsaAw4sdNtQ+SN3KUc1OYIZcJcooeQyQiddmiHCXQocMxQMGAbOSxuQhHaujsGWfwoqkAOAry0xt9Ry0FLKCGmj5F0YUlO3trSKuuWQ0xmJdXUMXCEFZ3odZ7t2pN0kGsKFhWN5ZyMqQF9E7igSOfdTABEBAAG0KUpvbmFzIEhhaG5mZWxkIDxqb25hcy5oYWhuZmVsZEBvbmxpbmUuZGU+iQE5BBMBAgAjBQJSKg3hAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQkcnDPSxhrNs1lAgAjEpy/TTOPTLEmdjXJDWgDom7y1+jTBHk37r3zjwWDJCkwr3WmVAnhY9muwo/8gkltvYk6CqzrIuUNxO7pTCfduEE04S19xUxd5IXVSxQoBG+AgzqvDqBmRCwMbDRXQ1EMu7qmX4FtZfjUmCZumQTf8unHzgGE5TgmYPM+UAS528AAWjT526lkLRhoSJHQlSBdaWGjiexCSyF76SedsXboCs9cS47mBWDwZOEin3eyycQlM0xBBPtEABF+Tq7Bt5/W9jc+wIe1f0QaUedsga75UY9wRYWu7Sjs90 1WSpEpdF+beU48rqaxEWLmLWkQy/3Vl571F21U+XP Received-SPF: pass client-ip=2a03:4000:2a:2c1::1; envelope-from=hahnjo@hahnjo.de; helo=mail.hahnjo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22138 Archived-At: --=-LSaKReZC2aDlrDBRQflK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-11-28 at 22:11 +0100, Jean Abou Samra wrote: > Le dimanche 29 octobre 2023 =C3=A0 10:51 +0100, Jonas Hahnfeld a =C3=A9cr= it=C2=A0: > > while playing with current Guile main on Windows, I found some problems > > in the implementation of custom-ports that was recently committed. > > Please consider the attached patches. >=20 > Not a Guile maintainer obviously, but: could you explain what the first > patch is for? It's not going to hurt, but I don't see what problem it fix= es. Sure: It makes sure that the extension is loaded also when not having a compiled custom-ports.go. For reference, see the documentation at https://www.gnu.org/software/guile/manual/html_node/Eval-When.html - the previously specified (load) only acts when loading a compiled module. During my tests, when chasing an incompatibility with the compiled bytecode, I was experimenting with just deleting some bytecode files. In that case, Guile should transparently fall back to evaluating the code. Which it did, only that the extension wasn't loaded and it complained loudly about unavailable symbols. So the solution is to at least specify (eval) for non-compiled code, but then the documentation mentions: "When in doubt, use the three conditions (expand load eval), as in the example above. Other uses of eval-when may void your warranty or poison your cat." This also matches all other uses of eval-when in the Guile source code itself. Let me know if I should try to improve the patch message. Jonas --=-LSaKReZC2aDlrDBRQflK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEXw/5YGpL6H9VOgO2kcnDPSxhrNsFAmVm3n4ACgkQkcnDPSxh rNs7aQf/XN5ETjDKoWg/CpkoegwHK9ZOv1rY9EDIBidS4TVK0PWBdqXwjq0gUxOO byN2SKYnCTT7/z7FGhHupNnK0ROmS6LTX3J5zHIQ+jCDC1/0GKcc6BcIYxCafp81 ykSm+sgSA0nTutqgHqHH2vqxcD64OPIXBeLANv2xJoO6cEcD4rM+6XMQ+WVf9Wbz yW6bcA6u5rSJDJt/5U95lktmapT5wOkW5W3qU2o+UgO6hggBoUt3l1GI5W9Il9wU jJ200BHFETFkDI8lZ1GLFI6ztKkBLwJeKQSrkIvD6qb8FHvaUKnnYeV7QviMbblE +ILeDmdVltK3iQMGyfLDj8mTCPXDjw== =1aLb -----END PGP SIGNATURE----- --=-LSaKReZC2aDlrDBRQflK--