From: "Linus Björnstam" <linus.bjornstam@veryfast.biz>
To: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>,
guile-user <guile-user@gnu.org>,
guile-devel <guile-devel@gnu.org>
Subject: Re: Guile's time execution issues
Date: Wed, 22 Apr 2020 15:47:36 +0200 [thread overview]
Message-ID: <b6cb405b-ac15-486f-b31b-22789c3348df@www.fastmail.com> (raw)
In-Reply-To: <CA+XASoXVOZav2F3goYroXXU_9XfuJbL7yxYkYkTTZqcwzo_5PA@mail.gmail.com>
Hi Aleix
Try throwing the result of json->SCM away: (let ((a (call-with...))) 1). Then you can run a (gc) between runs. If the GC time increases then, maybe guile cannot release the memory?? I don't know, but there is some shared substring thing going on in guile, even though I think string-append doesn't do that.
Nice to see that my suggestions worked!
--
Linus Björnstam
On Wed, 22 Apr 2020, at 00:03, Aleix Conchillo Flaqué wrote:
> Hi,
>
> I was trying to get some guile-json performance times loading large
> JSON file. However, I'm getting increasing numbers at each run, so I'm
> wondering if I'm doing something wrong. Below you can see how the first
> run took 19.95s and then running the same command kept increasing.
>
> I'm running Guile 2.2.7 on macOS Catalina 10.15.3.
>
> scheme@(guile-user)> (use-modules (json))
> scheme@(guile-user)> ,t (define a (call-with-input-file
> "/Users/aleix/Downloads/large-file.json" (lambda (port) (json->scm
> port))))
> ;; 19.956429s real time, 87.100982s run time. 75.270202s spent in GC.
> ;; 26.173179s real time, 143.645265s run time. 131.022631s spent in GC.
> ;; 28.193926s real time, 154.758375s run time. 141.697236s spent in GC.
> ;; 29.044218s real time, 160.745984s run time. 147.449073s spent in GC.
> ;; 30.480873s real time, 170.855527s run time. 157.332793s spent in GC.
> ;; 30.555700s real time, 172.938278s run time. 159.468737s spent in GC.
> ;; 32.190478s real time, 172.807551s run time. 158.905645s spent in GC.
>
> The good news is that I have applied a suggestion from Linus Björnstam
> that reduces times by half (considering the first run above). The
> suggestion was to use string ports instead of string-append. And
> interestingly this time, time executions remain around the same value:
>
> scheme@(guile-user)> ,t (define a (call-with-input-file
> "/Users/aleix/Downloads/large-file.json" (lambda (port) (json->scm
> port))))
> ;; 9.099597s real time, 17.239176s run time. 9.309819s spent in GC.
> ;; 9.927868s real time, 20.855859s run time. 12.528727s spent in GC.
> ;; 8.981248s real time, 15.043991s run time. 7.050269s spent in GC.
> ;; 9.055893s real time, 15.400981s run time. 7.383187s spent in GC.
> ;; 9.055850s real time, 15.261824s run time. 7.239188s spent in GC.
> ;; 9.315239s real time, 15.231889s run time. 7.005570s spent in GC.
> ;; 9.106168s real time, 14.987678s run time. 6.915028s spent in GC.
> ;; 9.175142s real time, 14.471324s run time. 6.302749s spent in GC.
> ;; 8.966537s real time, 14.400318s run time. 6.412858s spent in GC.
>
> JSON test data obtained from:
>
> https://github.com/json-iterator/test-data/blob/master/large-file.json
>
> Best,
>
> Aleix
next prev parent reply other threads:[~2020-04-22 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 22:03 Guile's time execution issues Aleix Conchillo Flaqué
2020-04-22 13:47 ` Linus Björnstam [this message]
2020-04-26 17:16 ` Ludovic Courtès
2020-04-26 23:14 ` Aleix Conchillo Flaqué
2020-05-02 14:11 ` Ludovic Courtès
2020-05-04 0:32 ` Aleix Conchillo Flaqué
2020-05-04 9:36 ` Ludovic Courtès
2020-05-04 11:19 ` Linus Björnstam
2020-05-04 20:09 ` Ludovic Courtès
2020-05-04 20:50 ` Linus Björnstam
2020-05-08 11:31 ` Linus Björnstam
2020-05-04 18:47 ` Linus Björnstam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6cb405b-ac15-486f-b31b-22789c3348df@www.fastmail.com \
--to=linus.bjornstam@veryfast.biz \
--cc=aconchillo@gmail.com \
--cc=guile-devel@gnu.org \
--cc=guile-user@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).