From: Maxime Devos <maximedevos@telenet.be>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>, guile-devel@gnu.org
Subject: Re: GC + Java finalization
Date: Fri, 19 Nov 2021 14:14:44 +0000 [thread overview]
Message-ID: <b5594307936a14b635ae0af159f6fd99ef6ba60d.camel@telenet.be> (raw)
In-Reply-To: <5f9eec1969de97273cb0c335587ba98080225f6e.camel@hahnjo.de>
Jonas Hahnfeld schreef op vr 19-11-2021 om 14:55 [+0100]:
> Am Freitag, dem 19.11.2021 um 13:48 +0000 schrieb Maxime Devos:
> > Jonas Hahnfeld schreef op vr 19-11-2021 om 14:32 [+0100]:
> > > > > - rx = scm_gc_malloc_pointerless (sizeof (regex_t),
> > > > > "regex");
> > > > > + rx = scm_malloc (sizeof (regex_t));
> > > >
> > > > If the regex why scm_gc_malloc_pointerless -> scm_malloc?
> > > > Is rx not pointerless?
> > >
> > > Not sure I understand the question. We don't know what contents
> > > libc
> > > will write into regex_t. It could be pointers which would be bad
> > > for
> > > the garbage collector.
> >
> > OK, if that's the case, seems like a bug in the original code, not
> > related to Java-style finalisation, so I would do that in a
> > separate
> > patch.
From your other responses, I now know it is actually related to (non-
)Java style finalisation, but my comment about ‘separate patch’ still
seems to apply:
>
> Again, as replied in July to the same comment, it *is* a separate
> patch
> for exactly this reason.
More concretely, it is in the same patch as that modified
libguile/random.c. The patch to libguile/random.c doesn't seem to
be for non-Java finalization reasons. Going by the commit message,
the only possible reason I could find is:
‘There is no point in registering memory with the garbage collector
if it doesn't need to do its job’
But I don't see any ‘registering memory’, only replacing
scm_gc_calloc+scm_gc_free by scm_calloc+free, and without any
finalisation in sight. Unless you mean with ‘registering memory’
the "random bignum chunks" argument. But that still seems unrelated
to non-Java finalization.
Greetings,
Maxime
next prev parent reply other threads:[~2021-11-19 14:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 12:05 GC + Java finalization Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-07-03 17:14 ` Maxime Devos
2021-07-03 17:26 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-07-03 18:49 ` Maxime Devos
2021-07-03 18:54 ` Maxime Devos
2021-07-15 18:44 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-10-10 16:22 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 12:18 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2022-02-22 10:14 ` Dr. Arne Babenhauserheide
2022-02-22 15:12 ` Mike Gran
2021-11-19 13:13 ` Maxime Devos
2021-11-19 13:32 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:35 ` Maxime Devos
2021-11-19 13:40 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:44 ` Maxime Devos
2021-11-19 13:53 ` Maxime Devos
2021-11-19 13:53 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:01 ` Maxime Devos
2021-11-19 13:48 ` Maxime Devos
2021-11-19 13:55 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:14 ` Maxime Devos [this message]
2021-11-19 14:52 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 18:48 ` Maxime Devos
2021-11-19 19:01 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:15 ` Maxime Devos
2021-11-19 13:35 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:21 ` Maxime Devos
2021-11-19 15:32 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:17 ` Maxime Devos
2021-11-19 13:38 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-20 9:19 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5594307936a14b635ae0af159f6fd99ef6ba60d.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=guile-devel@gnu.org \
--cc=hahnjo@hahnjo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).