From: Maxime Devos <maximedevos@telenet.be>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>, guile-devel@gnu.org
Subject: Re: GC + Java finalization
Date: Fri, 19 Nov 2021 14:21:08 +0000 [thread overview]
Message-ID: <b3880e9f5f4535e797abb5110f7474db5abdb5ad.camel@telenet.be> (raw)
In-Reply-To: <89404d642bd0225001e78d331c88849f67da5254.camel@hahnjo.de>
Jonas Hahnfeld schreef op vr 19-11-2021 om 14:35 [+0100]:
> Am Freitag, dem 19.11.2021 um 13:15 +0000 schrieb Maxime Devos:
> > Jonas Hahnfeld schreef op do 15-07-2021 om 20:44 [+0200]:
> > > + SCM *smobs = scm_gc_malloc (sizeof(SCM) * SMOBS_COUNT,
> > > "smobs");
> > > +
> > > int i;
> > > mark_call_count = 0;
> > > for (i = 0; i < SMOBS_COUNT; i++)
> > > - make_x ();
> > > + smobs[i] = make_x ();
> > > scm_gc ();
> >
> > smobs doesn't need to be protected for the whole function call,
> > until after the scm_gc() should be sufficient I think.
>
> That's what the patch does, no? For reference, the whole function
> (after this patch) looks like:
>
> SCM *smobs = scm_gc_malloc (sizeof(SCM) * SMOBS_COUNT, "smobs");
>
> int i;
> mark_call_count = 0;
> for (i = 0; i < SMOBS_COUNT; i++)
> smobs[i] = make_x ();
> scm_gc ();
> if (mark_call_count < SMOBS_COUNT)
> {
> fprintf (stderr, "FAIL: SMOB mark function called for each
> SMOB\n");
> exit (EXIT_FAILURE);
> }
> scm_remember_upto_here_1 (smobs);
>
> While we could move the remember_upto_here immediately after the call
> to scm_gc(), the current version ensures that the memory is still
> available when the error is checked.
The error checking code (I'm thinking of the if (mark_call_count ...)
fprintf(...) exit(...) here) isn't using 'smobs', so the error checking
code doesn't need the memory to be available AFAIK.
Greetings,
Maxime Devos.
next prev parent reply other threads:[~2021-11-19 14:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 12:05 GC + Java finalization Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-07-03 17:14 ` Maxime Devos
2021-07-03 17:26 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-07-03 18:49 ` Maxime Devos
2021-07-03 18:54 ` Maxime Devos
2021-07-15 18:44 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-10-10 16:22 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 12:18 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2022-02-22 10:14 ` Dr. Arne Babenhauserheide
2022-02-22 15:12 ` Mike Gran
2021-11-19 13:13 ` Maxime Devos
2021-11-19 13:32 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:35 ` Maxime Devos
2021-11-19 13:40 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:44 ` Maxime Devos
2021-11-19 13:53 ` Maxime Devos
2021-11-19 13:53 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:01 ` Maxime Devos
2021-11-19 13:48 ` Maxime Devos
2021-11-19 13:55 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:14 ` Maxime Devos
2021-11-19 14:52 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 18:48 ` Maxime Devos
2021-11-19 19:01 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:15 ` Maxime Devos
2021-11-19 13:35 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:21 ` Maxime Devos [this message]
2021-11-19 15:32 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:17 ` Maxime Devos
2021-11-19 13:38 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-20 9:19 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3880e9f5f4535e797abb5110f7474db5abdb5ad.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=guile-devel@gnu.org \
--cc=hahnjo@hahnjo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).