From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: Re: GC + Java finalization Date: Fri, 19 Nov 2021 13:35:37 +0000 Message-ID: References: <9ce77d5e08d50456eddc575179b68ac17afc9bf6.camel@hahnjo.de> <1cc3648e5196bf23023ec7a0ab95a9ad46f8554c.camel@telenet.be> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-jQ1lAyWQ+kp91y3rpywD" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.38.3-1 To: Jonas Hahnfeld , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Fri Nov 19 14:43:04 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mo4AR-0008lB-N0 for guile-devel@m.gmane-mx.org; Fri, 19 Nov 2021 14:43:03 +0100 Original-Received: from localhost ([::1]:40250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo4AQ-0004JO-92 for guile-devel@m.gmane-mx.org; Fri, 19 Nov 2021 08:43:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo43L-0005vv-Rg for guile-devel@gnu.org; Fri, 19 Nov 2021 08:35:43 -0500 Original-Received: from [2a02:1800:120:4::f00:14] (port=53746 helo=xavier.telenet-ops.be) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo43J-0000d8-2C for guile-devel@gnu.org; Fri, 19 Nov 2021 08:35:43 -0500 Original-Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by xavier.telenet-ops.be with bizsmtp id LDbe260024UW6Th01DbedF; Fri, 19 Nov 2021 14:35:38 +0100 In-Reply-To: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1637328938; bh=3/+cBDVDSPs7cOeZhGTDuy7iPcyPNxTHjzG6QeoDmV0=; h=Subject:From:To:Date:In-Reply-To:References; b=I/pQKZK+2iZP4r+bmWbHlmwWU+8AXT20RrKVrlmYG+JFXkRUrG8dN30ukUiujRor1 vsSz0/0ohigXzTsU5nczj+Ko+n+Oic5Ulxk1yc3pI0zwPz9cPfmgbeGOFLzS+J9lcd BLr2QUfuwKRQzXPEqxHdC/0PnqO5yqyiq4+hrMId6nvAYkLChXuiQZq+06dkd8hWny vckiAwV1QYTjP9HCt3/beUHJAcXGhf4yo+KwmnSNuo8Do4Fl9/iK/Ane42euNX5R6A ZybmF69IGHv7CeRvYYxBTSmddG28We+peiCvML8rxyMTwnqyVM0lKi+GWMpC0b/R8u 6QDa30Eppk69w== X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:1800:120:4::f00:14 (failed) Received-SPF: pass client-ip=2a02:1800:120:4::f00:14; envelope-from=maximedevos@telenet.be; helo=xavier.telenet-ops.be X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20962 Archived-At: --=-jQ1lAyWQ+kp91y3rpywD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Jonas Hahnfeld schreef op vr 19-11-2021 om 14:32 [+0100]: > > You coud simply ... > > > > > > > -      scm_gc_free (rx, sizeof(regex_t), "regex"); > > > +      free (rx); > > > > drop the scm_gc_free AFAIK. > > No, I cannot as explained in the patch summary: If we use scm_gc_free > in a free function of a Smob, this relies on Java finalization > because > the memory must not be reclaimed in the same cycle. The suggestion was to remove scm_gc_free, and not introduce free. I.e., don't free rx manually at all, let boehmgc decide:  regex_free (SCM obj)  {    regfree (SCM_RGX (obj)); -  scm_gc_free (SCM_RGX (obj), sizeof(regex_t), "regex");    return 0;  } Greetings, Maxime --=-jQ1lAyWQ+kp91y3rpywD Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Jonas Hahnfeld schreef op vr 19-11-2021 om 14= :32 [+0100]:
&= gt; You coud simply ...
> <= /font>
>
> > -      scm_gc_free = (rx, sizeof(regex_t), "regex");
> > +      free (rx);
>
> drop the scm_gc_free AFAIK.

No, I cannot as = explained in the patch summary: If we use scm_gc_free
in a free function= of a Smob, this relies on Java finalization because
the memory must not= be reclaimed in the same cycle.

= The suggestion was to remove scm_gc_free, and not introduce free.
I.e., don't free rx manually at all, let boehmgc decide:

 regex_free (SCM obj)
 {
-  scm_gc_free (SCM_RGX (obj), sizeof(regex_t), "regex");
   return 0;
 }

Greetings,
Maxime
--=-jQ1lAyWQ+kp91y3rpywD--