From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Volf <~@wolfsden.cz> Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add more detailed instructions into the HACKING file. Date: Tue, 5 Dec 2023 00:12:47 +0100 Message-ID: References: <20231129164054.15881-1-~@wolfsden.cz> <05c6e190-e0ff-fa79-5583-91c2a5def33e@telenet.be> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mKgy9VP/wXcXBrXj" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35791"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Maxime Devos Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Tue Dec 05 00:13:41 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAI8B-00096B-T5 for guile-devel@m.gmane-mx.org; Tue, 05 Dec 2023 00:13:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAI7j-0001yV-AM; Mon, 04 Dec 2023 18:13:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAI7h-0001y9-E8 for guile-devel@gnu.org; Mon, 04 Dec 2023 18:13:09 -0500 Original-Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAI7U-0005jw-7B for guile-devel@gnu.org; Mon, 04 Dec 2023 18:13:09 -0500 Original-Received: by wolfsden.cz (Postfix, from userid 104) id 26D03264645; Mon, 4 Dec 2023 23:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1701731569; bh=bZTYM2D07j2ZbIEoYei6SduTdjq59TpoJWrzK8SKIUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=BuG8vc2JPz1sCm7bq6FjpKW8F0CbFjT0k4cWglQAc5JAWqJU5k7u3N86gyr9KTE+a UYVblevlipvZq+MiK0wl9rO0u0rGAcMbUZqEoEhGad/FyWidaI/BznaHFeL9z6wJQe 2FPvLd6VcTpU37ZPtHbZlLuTc5hYo0Y7MKa/0dnw0jvVxXIhE+Fnj5w3GpT5NFJUB+ GGk7P5zng7BG4amoxs1IWXf/oVhG/X96GSSEKDUCmo12RYiWq2tS2DQhuzl6sXznKw op1Y8TvafwH96u6aVBCnE1hd77jrsznL0R/OhRWS1YV0C3DNodD+JiFtfV8Afat8dx s/dRxLcGmtaDMb7pJlDGJUrAGB5eFjNDqN6tztEyUVGzZAdqbZznh1YXOhXWIHC3NX wO4r/SN70d5sZkFLKc8vQyc3SSK4RZcBkFKsqY8E6GbUoFu1S6Pbw6OYywOjZZBunV hoyPn5QX6giVSNfzooNqGPvi/cgmwgpAIxHQNpW0mxLZkMdNMWv4y8g7Ffr+exGi0H 3vu42oYADJfOoRVP/HqKzVWntPjFAyCUOBhRzfDlekRJYzSmPQDcqAjVPnIkgWI6lF i4TFQ1I1lxD//LO96ZxElyt+vPrTBbTaRw2Jj5EDCFsH2lIw2CfrkT3+58OuDCYGQb QbfbBhW4ejzbTCqzNHbEA6nk= Original-Received: from localhost (unknown [193.32.127.157]) by wolfsden.cz (Postfix) with ESMTPSA id 2A2C5263E9D; Mon, 4 Dec 2023 23:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1701731568; bh=bZTYM2D07j2ZbIEoYei6SduTdjq59TpoJWrzK8SKIUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oKj775V6v4l78ZETHGCrR0rP+Er0eeLMH4zO9pcKvXJ8GJyBGZt19xk1sWuz6BDbx /FXiTDwvAoh3IktU15U/YLsxDRRhAo8mAtbkzP4BuX1++Srir2WEmo4QlxjNAAIni4 slfKM4yACtm1uzcqSU72UumHskVzm//RxDMRV3eA3CNPJ1xvOZNmDLz4E/WUf3t2Y6 NXPfJ06Arc/kgsd7XwF7B2YSXM/YLgWgaF9ZgaVw6Xg1osgjfWzl5JCzZOQvvIS/N0 79BMlTjCwX5TFxdAQkJSHvYoecalcNQ065sjAiRylyLcOw7LP+0lFM+AdshFWTkrj/ 9mkxAynHMvZM35DrgN8pt81HJW4sEArT5Kesi+wAHhKSe0hjxCAsri/iIIz0GytSn6 CJWjVVvG304aXNUs7H5t+LmYD6HxPNn66RFGsPa6sZzSOq9DPr1ZEPQocLO2lvARij m2sE9KoIxHbs2nYEasDbyqoSWiGXSOiLBMGkG4U2D3IamOrlSWETXazCxLTDnKx1Wx hiK1JvrynikxztGrDRyy+0ik3M2dIHJjftABl+X34z2RItF8c5b1tSK9hYo8Z8sAQd mfB6Zn/5aVwvSr3VtrNgcLi8iZ1Q0t4dir3rgwoys+WvuuvLz6uOJZHxZ4p76Ibai5 RRprCyi7bXI57ku4k6wBCVsk= Original-Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 7f7cd41d; Mon, 4 Dec 2023 23:12:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <05c6e190-e0ff-fa79-5583-91c2a5def33e@telenet.be> Received-SPF: none client-ip=37.205.8.62; envelope-from=ws@wolfsnet.cz; helo=wolfsden.cz X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22201 Archived-At: --mKgy9VP/wXcXBrXj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thank you for the review. On 2023-12-04 22:06:42 +0100, Maxime Devos wrote: > > > Op 29-11-2023 om 17:40 schreef Tomas Volf: > > + guix shell -D -f guix.scm --pure -- ./configure --enable-mini-gmp > > Also -fexcess-precision=standard (see #49368 / #49659 on debbugs) (at least > for i*86, should be harmless for other architectures though). That explains why I did not catch it (I did run the test suite, but I am on x86_64). Out of curiosity, since it should be harmless elsewhere, is there a reason this is not a flag set by default? > > Also --disable-jit when on the Hurd. > > You might want to check if static libraries are built by default (*), and if > so, add --disable-static to reduce compilation time. > > (*) can be tested with "find . -name '*.a'" after "make" -- don't worry > about libgnu.a, IIUC only libguile-3.0.a / .so is important. > > Best regards, > Maxime Devos. I added a note regarding the Hurd and the disabling of static libraries. Will send v2. Have a nice day, Tomas Volf -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --mKgy9VP/wXcXBrXj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmVuXO8ACgkQL7/ufbZ/ wanS5g//bKJfKvC682in/o1BG293fy34xqbk7kG2QHt32R8lnQG/SUVQnt5WUwfz Lul4XfejRvpgIFKCXXJsJBGWQZno936/kiuE8cyud0MPGvZHklQTnuc+659yq3s8 xUIp4VfWGr5SaVW9vhvyms9ewHH8W2w8xvKG8ktgwCPjc/N+qWljmWzUXS958mW+ HA17ar308trJ5KBTWVVr6btv0cGN1QnjJZStAL3OhI8Rdpw5EKuy8fwaxTd4kla6 iLwiJ6k3qtY4ToyFuaz4mozJDukH2n+9hhdLSETFaUheQ5xIJPa4G0KyW1dawzUY EHqUYxr3op58X1l605LtTB4unl3pGjt98RMxWh3B5cFQVr9/gtyloPxKO2a3pUIf G3/mQVKGWricnoTVF4cBPapxdCKKXTqYkaBvS1I0/WF9fmUxiFktaBBeVx6dIM6C oBq1fVwDM6fO7v2w9sFzyy3hx+ov5uk7NmrzMosrJG6CJLbi/C7CJI6bAwRElHh4 SQUNU/oM6FjMJ2TOVNKr4t/EIIDIcb0Dj1lZsmQtrvALz6fLosahu4sUj+nb1oiS xAJOZ9lni5AeXLidGIDyofIZ1ldTqc/hx6YVutoFB2Aums3rTkgG9su6KPmEfHdu Eak33vu6DXbfQNuXOPbU87UGiywmIjlEv849HvZW/6wzI/kHUk4= =DOjB -----END PGP SIGNATURE----- --mKgy9VP/wXcXBrXj--