Re: [PATCH] Add more detailed instructions into the HACKING file.

[Tomas Volf <~@wolfsden.cz>]

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

Thank you for the review.

On 2023-12-04 22:06:42 +0100, Maxime Devos wrote:
>
>
> Op 29-11-2023 om 17:40 schreef Tomas Volf:
> > +    guix shell -D -f guix.scm --pure -- ./configure --enable-mini-gmp
>
> Also -fexcess-precision=standard (see #49368 / #49659 on debbugs) (at least
> for i*86, should be harmless for other architectures though).

That explains why I did not catch it (I did run the test suite, but I am on
x86_64).

Out of curiosity, since it should be harmless elsewhere, is there a reason this
is not a flag set by default?

>
> Also --disable-jit when on the Hurd.
>
> You might want to check if static libraries are built by default (*), and if
> so, add --disable-static to reduce compilation time.
>
> (*) can be tested with "find . -name '*.a'" after "make" -- don't worry
> about libgnu.a, IIUC only libguile-3.0.a / .so is important.
>
> Best regards,
> Maxime Devos.

I added a note regarding the Hurd and the disabling of static libraries.

Will send v2.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]