From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "David A. Wheeler" Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Per-port read options, reader directives, SRFI-105 Date: Wed, 24 Oct 2012 17:52:13 -0400 (EDT) Message-ID: References: <87a9vmvh9s.fsf@tines.lan> <87mwzdzpqf.fsf@tines.lan> <87r4onwv9e.fsf@tines.lan> Reply-To: dwheeler@dwheeler.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1351115537 21295 80.91.229.3 (24 Oct 2012 21:52:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2012 21:52:17 +0000 (UTC) Cc: almkglor@gmail.com, guile-devel@gnu.org To: mhw@netris.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Oct 24 23:52:25 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TR8sB-00027t-OR for guile-devel@m.gmane.org; Wed, 24 Oct 2012 23:52:23 +0200 Original-Received: from localhost ([::1]:54074 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR8s3-0002qo-OY for guile-devel@m.gmane.org; Wed, 24 Oct 2012 17:52:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR8s0-0002qH-1q for guile-devel@gnu.org; Wed, 24 Oct 2012 17:52:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR8rz-0006sa-5G for guile-devel@gnu.org; Wed, 24 Oct 2012 17:52:11 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:58293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR8ry-0006ry-V3 for guile-devel@gnu.org; Wed, 24 Oct 2012 17:52:11 -0400 Original-Received: from [10.9.9.131] (helo=fenris.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1TR8rx-0003uQ-3K; Wed, 24 Oct 2012 23:52:09 +0200 Original-Received: from mail by fenris.runbox.com with local (Exim 4.50) id 1TR8s1-0003Wr-UZ; Wed, 24 Oct 2012 23:52:13 +0200 Content-Disposition: inline Original-Received: from [129.246.254.217] by secure.runbox.com with http (uid:258406) (RMM 4.0); Wed, 24 Oct 2012 21:52:13 GMT X-Mailer: RMM In-Reply-To: <87r4onwv9e.fsf@tines.lan> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 91.220.196.211 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15047 Archived-At: Mark H Weaver: > Here's an improved version of the patch set, incorporating Ludovic's > suggestions and rebased on the current stable-2.0 branch. I haven't had a chance to review the code in depth, but I find it *very* en= couraging that this patch includes a nice long test suite for SRFI-105. In= particular, I appreciate that this patch includes a test for "{f{n - 1}(x)= }". That one is important, because older versions of the reference impleme= ntation got that wrong (the spec requires left-to-right, but the code in th= at case accidentally did right-to-left). So that's a case particularly wor= th checking (and it does). --- David A. Wheeler