From: "David A. Wheeler" <dwheeler@dwheeler.com>
To: mhw@netris.org
Cc: almkglor@gmail.com, guile-devel@gnu.org
Subject: Re: [PATCH] Per-port read options, reader directives, SRFI-105
Date: Wed, 24 Oct 2012 17:52:13 -0400 (EDT) [thread overview]
Message-ID: <E1TR8s1-0003Wr-UZ@fenris.runbox.com> (raw)
In-Reply-To: <87r4onwv9e.fsf@tines.lan>
Mark H Weaver:
> Here's an improved version of the patch set, incorporating Ludovic's
> suggestions and rebased on the current stable-2.0 branch.
I haven't had a chance to review the code in depth, but I find it *very* encouraging that this patch includes a nice long test suite for SRFI-105. In particular, I appreciate that this patch includes a test for "{f{n - 1}(x)}". That one is important, because older versions of the reference implementation got that wrong (the spec requires left-to-right, but the code in that case accidentally did right-to-left). So that's a case particularly worth checking (and it does).
--- David A. Wheeler
next prev parent reply other threads:[~2012-10-24 21:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 10:32 [PATCH] Per-port read options, reader directives, SRFI-105 Mark H Weaver
2012-10-23 6:06 ` Mark H Weaver
2012-10-23 20:44 ` Ludovic Courtès
2012-10-23 20:45 ` Ludovic Courtès
2012-10-23 20:53 ` Ludovic Courtès
2012-10-23 20:54 ` Ludovic Courtès
2012-10-23 20:57 ` Ludovic Courtès
2012-10-23 20:58 ` Ludovic Courtès
2012-10-23 21:26 ` Ludovic Courtès
2012-10-24 4:04 ` Mark H Weaver
2012-10-24 13:13 ` Ludovic Courtès
2012-10-24 14:41 ` Mark H Weaver
2012-10-26 17:30 ` Ludovic Courtès
2012-10-23 21:30 ` Ludovic Courtès
2012-10-24 19:00 ` Mark H Weaver
2012-10-24 21:52 ` David A. Wheeler [this message]
2012-10-26 17:41 ` Ludovic Courtès
2012-10-26 17:44 ` Ludovic Courtès
2012-10-26 21:21 ` Ludovic Courtès
2012-10-27 1:33 ` Mark H Weaver
2012-10-29 11:14 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1TR8s1-0003Wr-UZ@fenris.runbox.com \
--to=dwheeler@dwheeler.com \
--cc=almkglor@gmail.com \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).