From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Llorens Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Patchset related to array functions Date: Fri, 15 Jul 2016 14:54:12 +0200 Message-ID: References: <7EFBBC0B-FF29-418A-96DA-D1A323B66C95@bluewin.ch> <87twfv0wvm.fsf@pobox.com> <87poqg1rj5.fsf@pobox.com> <26F2BB49-7AD1-4DEC-87F4-0C4705A27378@bluewin.ch> <878tx4ytbr.fsf@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1468587286 24884 80.91.229.3 (15 Jul 2016 12:54:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Jul 2016 12:54:46 +0000 (UTC) Cc: guile-devel To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Jul 15 14:54:36 2016 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bO2dW-0002z0-CZ for guile-devel@m.gmane.org; Fri, 15 Jul 2016 14:54:34 +0200 Original-Received: from localhost ([::1]:60555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO2dV-0005Th-GT for guile-devel@m.gmane.org; Fri, 15 Jul 2016 08:54:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO2dP-0005KR-ML for guile-devel@gnu.org; Fri, 15 Jul 2016 08:54:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO2dL-0000s7-Fa for guile-devel@gnu.org; Fri, 15 Jul 2016 08:54:26 -0400 Original-Received: from zhbdzmsp-smta15.bluewin.ch ([195.186.99.132]:57546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO2dL-0000rc-8r for guile-devel@gnu.org; Fri, 15 Jul 2016 08:54:23 -0400 Original-Received: from [195.186.227.130] ([195.186.227.130:54437] helo=zhhdzmsp-smta12.bluewin.ch) by zhbdzmsp-smta15.bluewin.ch (envelope-from ) (ecelerity 3.5.10.45038 r(Core:3.5.10.0)) with ESMTP id 02/AB-01806-CFCD8875; Fri, 15 Jul 2016 12:54:21 +0000 Original-Received: from [10.0.1.14] (92.106.52.170) by zhhdzmsp-smta12.bluewin.ch (8.5.142) (authenticated as dll@bluewin.ch) id 5704C29B05838384; Fri, 15 Jul 2016 12:54:20 +0000 In-Reply-To: <878tx4ytbr.fsf@pobox.com> X-Mailer: Apple Mail (2.1878.6) X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 195.186.99.132 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18503 Archived-At: On 14 Jul 2016, at 20:20, Andy Wingo wrote: > I think the concerns are: >=20 > (1) Do inlined definitions get inlined? > (2) Are external definitions reified as well? > (3) Do we avoid reifying definitions in each compilation unit? > (4) Can you dlsym() an inline function? >=20 > All these answers should be yes. No benchmarking needed, just > inspection of the build artifacts under different configurations. Right. I might give this a try. But IMO neither this inline issue nor = the stdint issue nor other things that we might want to improve thanks = to C99 are necessary to simply enable using C99 in the source. The = SCM_INLINE_etc defines work as they are and everything else seems to be = backwards compatible. The fixes are more likely to happen once the C99 = switch has been flipped. > Tx, will review separately. In the future would you mind please > spamming the list with these patches as a thread of multiple mails, as > git-send-email would do? That makes it easy for me to review just one > patch, say LGTM or whatever on that patch, then work on other patches = on > other days. But I will make an initial pass on this mail, later = though > :) I didn't know about git-send-mail, it's neat. It should be mentioned in = HACKING! I can resend the patches in that format, just let me know.